/* GTK - The GIMP Toolkit
 * Copyright (C) 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald
 * GtkToolbar copyright (C) Federico Mena
 *
 * Copyright (C) 2002 Anders Carlsson <andersca@gnome.org>
 * Copyright (C) 2002 James Henstridge <james@daa.com.au>
 * Copyright (C) 2003, 2004 Soeren Sandmann <sandmann@daimi.au.dk>
 * 
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the
 * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 * Boston, MA 02111-1307, USA.
 */

/*
 * Modified by the GTK+ Team and others 1997-2000.  See the AUTHORS
 * file for a list of people on the GTK+ Team.  See the ChangeLog
 * files for a list of changes.  These files are distributed with
 * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
 */

/* 2004-03-16
   Modified for Gtk24 backports by Yoichi Imai <yoichi@silver-forest.com>
   Available from Loqui <http://loqui.good-day.net/>
*/

#undef GTK_DISABLE_DEPRECATED

#include <config.h>

#ifdef USE_GTK_2_2

#include <gtk/gtkarrow.h>
#include "gtk24toolbar.h"
#include "gtkradiotoolbutton.h"
#include "gtkseparatortoolitem.h"
#include <gtk/gtkmenu.h>
#include <gtk/gtkradiobutton.h>
#include <gtk/gtkbindings.h>
#include <gdk/gdkkeysyms.h>
#include "gtk24marshalers.h"
#include <gtk/gtkmain.h>
#include <gtk/gtkstock.h>
#include <gtk/gtklabel.h>
#include <gtk/gtkprivate.h>
#include "gtkintl.h"
#include <string.h>
#include <gtk/gtkhbox.h>
#include <gtk/gtkvbox.h>
#include <gtk/gtkimage.h>
#include "gtk24ext.h"

typedef struct _ToolbarContent ToolbarContent;

#define DEFAULT_IPADDING 0

#define DEFAULT_SPACE_SIZE  12
#define DEFAULT_SPACE_STYLE GTK24_TOOLBAR_SPACE_LINE
#define SPACE_LINE_DIVISION 10.0
#define SPACE_LINE_START    2.0
#define SPACE_LINE_END      8.0

#define DEFAULT_ICON_SIZE GTK_ICON_SIZE_LARGE_TOOLBAR
#define DEFAULT_TOOLBAR_STYLE GTK_TOOLBAR_BOTH

#define MAX_HOMOGENEOUS_N_CHARS 13 /* Items that are wider than this do not participate
				    * in the homogeneous game. In units of
				    * pango_font_get_estimated_char_width().
				    */
#define SLIDE_SPEED 600	   /* How fast the items slide, in pixels per second */

/* Properties */
enum {
  PROP_0,
  PROP_ORIENTATION,
  PROP_TOOLBAR_STYLE,
  PROP_SHOW_ARROW
};

/* Child properties */
enum {
  CHILD_PROP_0,
  CHILD_PROP_EXPAND,
  CHILD_PROP_HOMOGENEOUS
};

/* Signals */
enum {
  ORIENTATION_CHANGED,
  STYLE_CHANGED,
  POPUP_CONTEXT_MENU,
  MOVE_FOCUS,
  FOCUS_HOME_OR_END,
  LAST_SIGNAL
};

/* API mode */
typedef enum {
  DONT_KNOW,
  OLD_API,
  NEW_API
} ApiMode;

typedef enum {
  TOOL_ITEM,
  COMPATIBILITY
} ContentType;

typedef enum {
  NOT_ALLOCATED,
  NORMAL,
  HIDDEN,
  OVERFLOWN,
} ItemState;

struct _Gtk24ToolbarPrivate
{
  GList	*	content;
  
  GtkWidget *	arrow;
  GtkWidget *	arrow_button;
  
  GtkMenu *	menu;
  
  GdkWindow *	event_window;
  ApiMode	api_mode;
  GtkSettings *	settings;
  int		idle_id;
  GtkToolItem *	highlight_tool_item;
  gint		max_homogeneous_pixels;
  
  GTimer *	timer;
  
  guint		show_arrow : 1;
  guint		need_sync : 1;
  guint		is_sliding : 1;
};

static void       gtk24_toolbar_init                 (Gtk24Toolbar          *toolbar);
static void       gtk24_toolbar_class_init           (Gtk24ToolbarClass     *klass);
static void       gtk24_toolbar_set_property         (GObject             *object,
						    guint                prop_id,
						    const GValue        *value,
						    GParamSpec          *pspec);
static void       gtk24_toolbar_get_property         (GObject             *object,
						    guint                prop_id,
						    GValue              *value,
						    GParamSpec          *pspec);
static gint       gtk24_toolbar_expose               (GtkWidget           *widget,
						    GdkEventExpose      *event);
static void       gtk24_toolbar_realize              (GtkWidget           *widget);
static void       gtk24_toolbar_unrealize            (GtkWidget           *widget);
static void       gtk24_toolbar_size_request         (GtkWidget           *widget,
						    GtkRequisition      *requisition);
static void       gtk24_toolbar_size_allocate        (GtkWidget           *widget,
						    GtkAllocation       *allocation);
static void       gtk24_toolbar_style_set            (GtkWidget           *widget,
						    GtkStyle            *prev_style);
static gboolean   gtk24_toolbar_focus                (GtkWidget           *widget,
						    GtkDirectionType     dir);
static void       gtk24_toolbar_screen_changed       (GtkWidget           *widget,
						    GdkScreen           *previous_screen);
static void       gtk24_toolbar_map                  (GtkWidget           *widget);
static void       gtk24_toolbar_unmap                (GtkWidget           *widget);
static void       gtk24_toolbar_set_child_property   (GtkContainer        *container,
						    GtkWidget           *child,
						    guint                property_id,
						    const GValue        *value,
						    GParamSpec          *pspec);
static void       gtk24_toolbar_get_child_property   (GtkContainer        *container,
						    GtkWidget           *child,
						    guint                property_id,
						    GValue              *value,
						    GParamSpec          *pspec);
static void       gtk24_toolbar_finalize             (GObject             *object);
static void       gtk24_toolbar_show_all             (GtkWidget           *widget);
static void       gtk24_toolbar_hide_all             (GtkWidget           *widget);
static void       gtk24_toolbar_add                  (GtkContainer        *container,
						    GtkWidget           *widget);
static void       gtk24_toolbar_remove               (GtkContainer        *container,
						    GtkWidget           *widget);
static void       gtk24_toolbar_forall               (GtkContainer        *container,
						    gboolean             include_internals,
						    GtkCallback          callback,
						    gpointer             callback_data);
static GType      gtk24_toolbar_child_type           (GtkContainer        *container);
static void       gtk24_toolbar_orientation_changed  (Gtk24Toolbar          *toolbar,
						    GtkOrientation       orientation);
static void       gtk24_toolbar_real_style_changed   (Gtk24Toolbar          *toolbar,
						    GtkToolbarStyle      style);
static gboolean   gtk24_toolbar_move_focus           (Gtk24Toolbar          *toolbar,
						    GtkDirectionType     dir);
static gboolean   gtk24_toolbar_focus_home_or_end    (Gtk24Toolbar          *toolbar,
						    gboolean             focus_home);
static gboolean   gtk24_toolbar_button_press         (GtkWidget           *toolbar,
						    GdkEventButton      *event);
static gboolean   gtk24_toolbar_arrow_button_press   (GtkWidget           *button,
						    GdkEventButton      *event,
						    Gtk24Toolbar          *toolbar);
static void       gtk24_toolbar_arrow_button_clicked (GtkWidget           *button,
						    Gtk24Toolbar          *toolbar);
static void       gtk24_toolbar_update_button_relief (Gtk24Toolbar          *toolbar);
static gboolean   gtk24_toolbar_popup_menu           (GtkWidget           *toolbar);
static GtkWidget *internal_insert_element          (Gtk24Toolbar          *toolbar,
						    Gtk24ToolbarChildType  type,
						    GtkWidget           *widget,
						    const char          *text,
						    const char          *tooltip_text,
						    const char          *tooltip_private_text,
						    GtkWidget           *icon,
						    GtkSignalFunc        callback,
						    gpointer             user_data,
						    gint                 position,
						    gboolean             use_stock);
static void       gtk24_toolbar_reconfigured         (Gtk24Toolbar          *toolbar);
static gboolean   gtk24_toolbar_check_new_api        (Gtk24Toolbar          *toolbar);
static gboolean   gtk24_toolbar_check_old_api        (Gtk24Toolbar          *toolbar);

static GtkReliefStyle       get_button_relief    (Gtk24Toolbar *toolbar);
static gint                 get_internal_padding (Gtk24Toolbar *toolbar);
static GtkShadowType        get_shadow_type      (Gtk24Toolbar *toolbar);
static gint                 get_space_size       (Gtk24Toolbar *toolbar);
static Gtk24ToolbarSpaceStyle get_space_style      (Gtk24Toolbar *toolbar);

/* methods on ToolbarContent 'class' */
static ToolbarContent *toolbar_content_new_tool_item        (Gtk24Toolbar          *toolbar,
							     GtkToolItem         *item,
							     gboolean             is_placeholder,
							     gint                 pos);
static ToolbarContent *toolbar_content_new_compatibility    (Gtk24Toolbar          *toolbar,
							     Gtk24ToolbarChildType  type,
							     GtkWidget           *widget,
							     GtkWidget           *icon,
							     GtkWidget           *label,
							     gint                 pos);
static void            toolbar_content_remove               (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar);
static void            toolbar_content_free                 (ToolbarContent      *content);
static void            toolbar_content_expose               (ToolbarContent      *content,
							     GtkContainer        *container,
							     GdkEventExpose      *expose);
static gboolean        toolbar_content_visible              (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar);
static void            toolbar_content_size_request         (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar,
							     GtkRequisition      *requisition);
static gboolean        toolbar_content_is_homogeneous       (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar);
static gboolean        toolbar_content_is_placeholder       (ToolbarContent      *content);
static gboolean        toolbar_content_disappearing         (ToolbarContent      *content);
static ItemState       toolbar_content_get_state            (ToolbarContent      *content);
static gboolean        toolbar_content_child_visible        (ToolbarContent      *content);
static void            toolbar_content_get_goal_allocation  (ToolbarContent      *content,
							     GtkAllocation       *allocation);
static void            toolbar_content_get_allocation       (ToolbarContent      *content,
							     GtkAllocation       *allocation);
static void            toolbar_content_set_start_allocation (ToolbarContent      *content,
							     GtkAllocation       *new_start_allocation);
static void            toolbar_content_get_start_allocation (ToolbarContent      *content,
							     GtkAllocation       *start_allocation);
static gboolean        toolbar_content_get_expand           (ToolbarContent      *content);
static void            toolbar_content_set_goal_allocation  (ToolbarContent      *content,
							     GtkAllocation       *allocation);
static void            toolbar_content_set_child_visible    (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar,
							     gboolean             visible);
static void            toolbar_content_size_allocate        (ToolbarContent      *content,
							     GtkAllocation       *allocation);
static void            toolbar_content_set_state            (ToolbarContent      *content,
							     ItemState            new_state);
static GtkWidget *     toolbar_content_get_widget           (ToolbarContent      *content);
static void            toolbar_content_set_disappearing     (ToolbarContent      *content,
							     gboolean             disappearing);
static void            toolbar_content_set_size_request     (ToolbarContent      *content,
							     gint                 width,
							     gint                 height);
static void            toolbar_content_toolbar_reconfigured (ToolbarContent      *content,
							     Gtk24Toolbar          *toolbar);
static GtkWidget *     toolbar_content_retrieve_menu_item   (ToolbarContent      *content);
static gboolean        toolbar_content_is_separator         (ToolbarContent      *content);
static void            toolbar_content_show_all             (ToolbarContent      *content);
static void            toolbar_content_hide_all             (ToolbarContent      *content);

#define GTK24_TOOLBAR_GET_PRIVATE(o) (GTK24_TOOLBAR(o)->priv)

static GtkContainerClass *	parent_class = NULL;
static guint			toolbar_signals [LAST_SIGNAL] = { 0 };

GType
gtk24_toolbar_get_type (void)
{
  static GtkType type = 0;
  
  if (!type)
    {
      static const GTypeInfo type_info =
	{
	  sizeof (Gtk24ToolbarClass),
	  (GBaseInitFunc) NULL,
	  (GBaseFinalizeFunc) NULL,
	  (GClassInitFunc) gtk24_toolbar_class_init,
	  (GClassFinalizeFunc) NULL,
	  NULL,
	  sizeof (Gtk24Toolbar),
	  0, /* n_preallocs */
	  (GInstanceInitFunc) gtk24_toolbar_init,
	};
      
      type = g_type_register_static (GTK_TYPE_CONTAINER,
				     "Gtk24Toolbar",
				     &type_info, 0);
    }
  
  return type;
}

static void
add_arrow_bindings (GtkBindingSet   *binding_set,
		    guint            keysym,
		    GtkDirectionType dir)
{
  guint keypad_keysym = keysym - GDK_Left + GDK_KP_Left;
  
  gtk_binding_entry_add_signal (binding_set, keysym, 0,
                                "move_focus", 1,
                                GTK_TYPE_DIRECTION_TYPE, dir);
  gtk_binding_entry_add_signal (binding_set, keypad_keysym, 0,
                                "move_focus", 1,
                                GTK_TYPE_DIRECTION_TYPE, dir);
}

static void
add_ctrl_tab_bindings (GtkBindingSet    *binding_set,
		       GdkModifierType   modifiers,
		       GtkDirectionType  direction)
{
  gtk_binding_entry_add_signal (binding_set,
				GDK_Tab, GDK_CONTROL_MASK | modifiers,
				"move_focus", 1,
				GTK_TYPE_DIRECTION_TYPE, direction);
  gtk_binding_entry_add_signal (binding_set,
				GDK_KP_Tab, GDK_CONTROL_MASK | modifiers,
				"move_focus", 1,
				GTK_TYPE_DIRECTION_TYPE, direction);
}

static void
gtk24_toolbar_class_init (Gtk24ToolbarClass *klass)
{
  GObjectClass *gobject_class;
  GtkWidgetClass *widget_class;
  GtkContainerClass *container_class;
  GtkBindingSet *binding_set;
  
  parent_class = g_type_class_peek_parent (klass);
  
  gobject_class = (GObjectClass *)klass;
  widget_class = (GtkWidgetClass *)klass;
  container_class = (GtkContainerClass *)klass;
  
  gobject_class->set_property = gtk24_toolbar_set_property;
  gobject_class->get_property = gtk24_toolbar_get_property;
  gobject_class->finalize = gtk24_toolbar_finalize;
  
  widget_class->button_press_event = gtk24_toolbar_button_press;
  widget_class->expose_event = gtk24_toolbar_expose;
  widget_class->size_request = gtk24_toolbar_size_request;
  widget_class->size_allocate = gtk24_toolbar_size_allocate;
  widget_class->style_set = gtk24_toolbar_style_set;
  widget_class->focus = gtk24_toolbar_focus;
  widget_class->screen_changed = gtk24_toolbar_screen_changed;
  widget_class->realize = gtk24_toolbar_realize;
  widget_class->unrealize = gtk24_toolbar_unrealize;
  widget_class->map = gtk24_toolbar_map;
  widget_class->unmap = gtk24_toolbar_unmap;
  widget_class->popup_menu = gtk24_toolbar_popup_menu;
  widget_class->show_all = gtk24_toolbar_show_all;
  widget_class->hide_all = gtk24_toolbar_hide_all;
  
  container_class->add    = gtk24_toolbar_add;
  container_class->remove = gtk24_toolbar_remove;
  container_class->forall = gtk24_toolbar_forall;
  container_class->child_type = gtk24_toolbar_child_type;
  container_class->get_child_property = gtk24_toolbar_get_child_property;
  container_class->set_child_property = gtk24_toolbar_set_child_property;
  
  klass->orientation_changed = gtk24_toolbar_orientation_changed;
  klass->style_changed = gtk24_toolbar_real_style_changed;
  
  /**
   * GtkToolbar::orientation-changed:
   * @toolbar: the object which emitted the signal
   * @orientation: the new #GtkOrientation of the toolbar
   *
   * Emitted when the orientation of the toolbar changes.
   */
  toolbar_signals[ORIENTATION_CHANGED] =
    g_signal_new ("orientation-changed",
		  G_OBJECT_CLASS_TYPE (klass),
		  G_SIGNAL_RUN_FIRST,
		  G_STRUCT_OFFSET (Gtk24ToolbarClass, orientation_changed),
		  NULL, NULL,
		  g_cclosure_marshal_VOID__ENUM,
		  G_TYPE_NONE, 1,
		  GTK_TYPE_ORIENTATION);
  /**
   * GtkToolbar::style-changed:
   * @toolbar: The #Gtk24Toolbar which emitted the signal
   * @style: the new #GtkToolbarStyle of the toolbar
   *
   * Emitted when the style of the toolbar changes. 
   */
  toolbar_signals[STYLE_CHANGED] =
    g_signal_new ("style-changed",
		  G_OBJECT_CLASS_TYPE (klass),
		  G_SIGNAL_RUN_FIRST,
		  G_STRUCT_OFFSET (Gtk24ToolbarClass, style_changed),
		  NULL, NULL,
		  g_cclosure_marshal_VOID__ENUM,
		  G_TYPE_NONE, 1,
		  GTK_TYPE_TOOLBAR_STYLE);
  /**
   * GtkToolbar::popup-context-menu:
   * @toolbar: the #Gtk24Toolbar which emitted the signal
   * @x: the x coordinate of the point where the menu should appear
   * @y: the y coordinate of the point where the menu should appear
   * @button: the mouse button the user pressed, or -1
   *
   * Emitted when the user right-clicks the toolbar or uses the
   * keybinding to display a popup menu.
   *
   * Application developers should handle this signal if they want
   * to display a context menu on the toolbar. The context-menu should
   * appear at the coordinates given by @x and @y. The mouse button
   * number is given by the @button parameter. If the menu was popped
   * up using the keybaord, @button is -1.
   *
   * Return value: return %TRUE if the signal was handled, %FALSE if not
   */
  toolbar_signals[POPUP_CONTEXT_MENU] =
    g_signal_new ("popup_context_menu",
		  G_OBJECT_CLASS_TYPE (klass),
		  G_SIGNAL_RUN_LAST,
		  G_STRUCT_OFFSET (Gtk24ToolbarClass, popup_context_menu),
		  _gtk_boolean_handled_accumulator, NULL,
		  _gtk24_marshal_BOOLEAN__INT_INT_INT,
		  G_TYPE_BOOLEAN, 3,
		  G_TYPE_INT, G_TYPE_INT,
		  G_TYPE_INT);
  /**
   * GtkToolbar::move-focus:
   * @toolbar: the #Gtk24Toolbar which emitted the signal
   * @dir: a #GtkDirection
   *
   * A keybinding signal used internally by GTK+. This signal can't
   * be used in application code.
   *
   * Return value: %TRUE if the signal was handled, %FALSE if not
   */
  toolbar_signals[MOVE_FOCUS] =
    _gtk_binding_signal_new ("move_focus",
			     G_TYPE_FROM_CLASS (klass),
			     G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
			     G_CALLBACK (gtk24_toolbar_move_focus),
			     NULL, NULL,
			     _gtk24_marshal_BOOLEAN__ENUM,
			     G_TYPE_BOOLEAN, 1,
			     GTK_TYPE_DIRECTION_TYPE);
  /**
   * GtkToolbar::focus-home-or-end:
   * @toolbar: the #Gtk24Toolbar which emitted the signal
   * @focus_home: %TRUE if the first item should be focused
   *
   * A keybinding signal used internally by GTK+. This signal can't
   * be used in application code
   *
   * Return value: %TRUE if the signal was handled, %FALSE if not
   */
  toolbar_signals[FOCUS_HOME_OR_END] =
    _gtk_binding_signal_new ("focus_home_or_end",
			     G_OBJECT_CLASS_TYPE (klass),
			     G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
			     G_CALLBACK (gtk24_toolbar_focus_home_or_end),
			     NULL, NULL,
			     _gtk24_marshal_BOOLEAN__BOOLEAN,
			     G_TYPE_BOOLEAN, 1,
			     G_TYPE_BOOLEAN);
  
  /* properties */
  g_object_class_install_property (gobject_class,
				   PROP_ORIENTATION,
				   g_param_spec_enum ("orientation",
 						      P_("Orientation"),
 						      P_("The orientation of the toolbar"),
 						      GTK_TYPE_ORIENTATION,
 						      GTK_ORIENTATION_HORIZONTAL,
 						      G_PARAM_READWRITE));
  
  g_object_class_install_property (gobject_class,
				   PROP_TOOLBAR_STYLE,
				   g_param_spec_enum ("toolbar_style",
 						      P_("Toolbar Style"),
 						      P_("How to draw the toolbar"),
 						      GTK_TYPE_TOOLBAR_STYLE,
 						      GTK_TOOLBAR_ICONS,
 						      G_PARAM_READWRITE));
  g_object_class_install_property (gobject_class,
				   PROP_SHOW_ARROW,
				   g_param_spec_boolean ("show_arrow",
							 P_("Show Arrow"),
							 P_("If an arrow should be shown if the toolbar doesn't fit"),
							 TRUE,
							 G_PARAM_READWRITE));
  
  /* child properties */
  gtk_container_class_install_child_property (container_class,
					      CHILD_PROP_EXPAND,
					      g_param_spec_boolean ("expand", 
								    P_("Expand"), 
								    P_("Whether the item should receive extra space when the toolbar grows"),
								    TRUE,
								    G_PARAM_READWRITE));
  
  gtk_container_class_install_child_property (container_class,
					      CHILD_PROP_HOMOGENEOUS,
					      g_param_spec_boolean ("homogeneous", 
								    P_("Homogeneous"), 
								    P_("Whether the item should be the same size as other homogeneous items"),
								    TRUE,
								    G_PARAM_READWRITE));
  
  /* style properties */
  gtk_widget_class_install_style_property (widget_class,
					   g_param_spec_int ("space_size",
							     P_("Spacer size"),
							     P_("Size of spacers"),
							     0,
							     G_MAXINT,
                                                             DEFAULT_SPACE_SIZE,
							     G_PARAM_READABLE));
  
  gtk_widget_class_install_style_property (widget_class,
					   g_param_spec_int ("internal_padding",
							     P_("Internal padding"),
							     P_("Amount of border space between the toolbar shadow and the buttons"),
							     0,
							     G_MAXINT,
                                                             DEFAULT_IPADDING,
                                                             G_PARAM_READABLE));
  
  gtk_widget_class_install_style_property (widget_class,
					   g_param_spec_enum ("space_style",
							      P_("Space style"),
							      P_("Whether spacers are vertical lines or just blank"),
                                                              GTK_TYPE_TOOLBAR_SPACE_STYLE,
                                                              DEFAULT_SPACE_STYLE,
                                                              G_PARAM_READABLE));
  
  gtk_widget_class_install_style_property (widget_class,
					   g_param_spec_enum ("button_relief",
							      P_("Button relief"),
							      P_("Type of bevel around toolbar buttons"),
                                                              GTK_TYPE_RELIEF_STYLE,
                                                              GTK_RELIEF_NONE,
                                                              G_PARAM_READABLE));
  gtk_widget_class_install_style_property (widget_class,
                                           g_param_spec_enum ("shadow_type",
                                                              P_("Shadow type"),
                                                              P_("Style of bevel around the toolbar"),
                                                              GTK_TYPE_SHADOW_TYPE,
                                                              GTK_SHADOW_OUT,
                                                              G_PARAM_READABLE));
  
  gtk_settings_install_property (g_param_spec_enum ("gtk-toolbar-style",
                                                    P_("Toolbar style"),
                                                    P_("Whether default toolbars have text only, text and icons, icons only, etc."),
                                                    GTK_TYPE_TOOLBAR_STYLE,
                                                    DEFAULT_TOOLBAR_STYLE,
                                                    G_PARAM_READWRITE));
  
  gtk_settings_install_property (g_param_spec_enum ("gtk-toolbar-icon-size",
                                                    P_("Toolbar icon size"),
                                                    P_("Size of icons in default toolbars"),
                                                    GTK_TYPE_ICON_SIZE,
                                                    DEFAULT_ICON_SIZE,
                                                    G_PARAM_READWRITE));  
  
  binding_set = gtk_binding_set_by_class (klass);
  
  add_arrow_bindings (binding_set, GDK_Left, GTK_DIR_LEFT);
  add_arrow_bindings (binding_set, GDK_Right, GTK_DIR_RIGHT);
  add_arrow_bindings (binding_set, GDK_Up, GTK_DIR_UP);
  add_arrow_bindings (binding_set, GDK_Down, GTK_DIR_DOWN);
  
  gtk_binding_entry_add_signal (binding_set, GDK_KP_Home, 0,
                                "focus_home_or_end", 1,
				G_TYPE_BOOLEAN, TRUE);
  gtk_binding_entry_add_signal (binding_set, GDK_Home, 0,
                                "focus_home_or_end", 1,
				G_TYPE_BOOLEAN, TRUE);
  gtk_binding_entry_add_signal (binding_set, GDK_KP_End, 0,
                                "focus_home_or_end", 1,
				G_TYPE_BOOLEAN, FALSE);
  gtk_binding_entry_add_signal (binding_set, GDK_End, 0,
                                "focus_home_or_end", 1,
				G_TYPE_BOOLEAN, FALSE);
  
  add_ctrl_tab_bindings (binding_set, 0, GTK_DIR_TAB_FORWARD);
  add_ctrl_tab_bindings (binding_set, GDK_SHIFT_MASK, GTK_DIR_TAB_BACKWARD);
  
  /* g_type_class_add_private (gobject_class, sizeof (GtkToolbarPrivate)); */
}

static void
gtk24_toolbar_init (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv;
  
  GTK_WIDGET_UNSET_FLAGS (toolbar, GTK_CAN_FOCUS);
  GTK_WIDGET_SET_FLAGS (toolbar, GTK_NO_WINDOW);

  toolbar->priv = g_new0(Gtk24ToolbarPrivate, 1);

  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  toolbar->orientation = GTK_ORIENTATION_HORIZONTAL;
  toolbar->style = DEFAULT_TOOLBAR_STYLE;
  toolbar->icon_size = DEFAULT_ICON_SIZE;
  toolbar->tooltips = gtk_tooltips_new ();
  g_object_ref (toolbar->tooltips);
  gtk_object_sink (GTK_OBJECT (toolbar->tooltips));
  
  priv->arrow_button = gtk_toggle_button_new ();
  g_signal_connect (priv->arrow_button, "button_press_event",
		    G_CALLBACK (gtk24_toolbar_arrow_button_press), toolbar);
  g_signal_connect (priv->arrow_button, "clicked",
		    G_CALLBACK (gtk24_toolbar_arrow_button_clicked), toolbar);
  gtk_button_set_relief (GTK_BUTTON (priv->arrow_button),
			 get_button_relief (toolbar));
  
  priv->api_mode = DONT_KNOW;
  
  gtk_button_set_focus_on_click (GTK_BUTTON (priv->arrow_button), FALSE);
  
  priv->arrow = gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_NONE);
  gtk_widget_set_name (priv->arrow, "gtk-toolbar-arrow");
  gtk_widget_show (priv->arrow);
  gtk_container_add (GTK_CONTAINER (priv->arrow_button), priv->arrow);
  
  gtk_widget_set_parent (priv->arrow_button, GTK_WIDGET (toolbar));
  
  /* which child position a drop will occur at */
  priv->menu = NULL;
  priv->show_arrow = TRUE;
  priv->settings = NULL;
  
  priv->max_homogeneous_pixels = -1;
  
  priv->timer = g_timer_new ();
}

static void
gtk24_toolbar_set_property (GObject      *object,
			  guint         prop_id,
			  const GValue *value,
			  GParamSpec   *pspec)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (object);
  
  switch (prop_id)
    {
    case PROP_ORIENTATION:
      gtk24_toolbar_set_orientation (toolbar, g_value_get_enum (value));
      break;
    case PROP_TOOLBAR_STYLE:
      gtk24_toolbar_set_style (toolbar, g_value_get_enum (value));
      break;
    case PROP_SHOW_ARROW:
      gtk24_toolbar_set_show_arrow (toolbar, g_value_get_boolean (value));
      break;
    default:
      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
      break;
    }
}

static void
gtk24_toolbar_get_property (GObject    *object,
			  guint       prop_id,
			  GValue     *value,
			  GParamSpec *pspec)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (object);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  switch (prop_id)
    {
    case PROP_ORIENTATION:
      g_value_set_enum (value, toolbar->orientation);
      break;
    case PROP_TOOLBAR_STYLE:
      g_value_set_enum (value, toolbar->style);
      break;
    case PROP_SHOW_ARROW:
      g_value_set_boolean (value, priv->show_arrow);
      break;
    default:
      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
      break;
    }
}

static void
gtk24_toolbar_map (GtkWidget *widget)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  
  GTK_WIDGET_CLASS (parent_class)->map (widget);
  
  if (priv->event_window)
    gdk_window_show_unraised (priv->event_window);
}

static void
gtk24_toolbar_unmap (GtkWidget *widget)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  
  if (priv->event_window)
    gdk_window_hide (priv->event_window);
  
  GTK_WIDGET_CLASS (parent_class)->unmap (widget);
}

static void
gtk24_toolbar_realize (GtkWidget *widget)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  GdkWindowAttr attributes;
  gint attributes_mask;
  gint border_width;
  
  GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED);
  
  border_width = GTK_CONTAINER (widget)->border_width;
  
  attributes.wclass = GDK_INPUT_ONLY;
  attributes.window_type = GDK_WINDOW_CHILD;
  attributes.x = widget->allocation.x + border_width;
  attributes.y = widget->allocation.y + border_width;
  attributes.width = widget->allocation.width - border_width * 2;
  attributes.height = widget->allocation.height - border_width * 2;
  attributes.event_mask = gtk_widget_get_events (widget);
  attributes.event_mask |= (GDK_BUTTON_PRESS_MASK |
			    GDK_BUTTON_RELEASE_MASK |
			    GDK_ENTER_NOTIFY_MASK |
			    GDK_LEAVE_NOTIFY_MASK);
  
  attributes_mask = GDK_WA_X | GDK_WA_Y;
  
  widget->window = gtk_widget_get_parent_window (widget);
  g_object_ref (widget->window);
  widget->style = gtk_style_attach (widget->style, widget->window);
  
  priv->event_window = gdk_window_new (gtk_widget_get_parent_window (widget),
				       &attributes, attributes_mask);
  gdk_window_set_user_data (priv->event_window, toolbar);
}

static void
gtk24_toolbar_unrealize (GtkWidget *widget)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  
  if (priv->event_window)
    {
      gdk_window_set_user_data (priv->event_window, NULL);
      gdk_window_destroy (priv->event_window);
      priv->event_window = NULL;
    }
  
  if (GTK_WIDGET_CLASS (parent_class)->unrealize)
    (* GTK_WIDGET_CLASS (parent_class)->unrealize) (widget);
}

static gint
gtk24_toolbar_expose (GtkWidget      *widget,
		    GdkEventExpose *event)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  GList *list;
  gint border_width;
  
  border_width = GTK_CONTAINER (widget)->border_width;
  
  if (GTK_WIDGET_DRAWABLE (widget))
    {
      gtk_paint_box (widget->style,
		     widget->window,
                     GTK_WIDGET_STATE (widget),
                     get_shadow_type (toolbar),
		     &event->area, widget, "toolbar",
		     border_width + widget->allocation.x,
                     border_width + widget->allocation.y,
		     widget->allocation.width - 2 * border_width,
                     widget->allocation.height - 2 * border_width);
    }
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      toolbar_content_expose (content, GTK_CONTAINER (widget), event);
    }
  
  gtk_container_propagate_expose (GTK_CONTAINER (widget),
				  priv->arrow_button,
				  event);
  
  return FALSE;
}

static void
gtk24_toolbar_size_request (GtkWidget      *widget,
			  GtkRequisition *requisition)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  gint max_child_height;
  gint max_child_width;
  gint max_homogeneous_child_width;
  gint max_homogeneous_child_height;
  gint homogeneous_size;
  gint long_req;
  gint pack_front_size;
  gint ipadding;
  GtkRequisition arrow_requisition;
  
  max_homogeneous_child_width = 0;
  max_homogeneous_child_height = 0;
  max_child_width = 0;
  max_child_height = 0;
  for (list = priv->content; list != NULL; list = list->next)
    {
      GtkRequisition requisition;
      ToolbarContent *content = list->data;
      
      if (!toolbar_content_visible (content, toolbar))
	continue;
      
      toolbar_content_size_request (content, toolbar, &requisition);

      max_child_width = MAX (max_child_width, requisition.width);
      max_child_height = MAX (max_child_height, requisition.height);
      
      if (toolbar_content_is_homogeneous (content, toolbar))
	{
	  max_homogeneous_child_width = MAX (max_homogeneous_child_width, requisition.width);
	  max_homogeneous_child_height = MAX (max_homogeneous_child_height, requisition.height);
	}
    }
  
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    homogeneous_size = max_homogeneous_child_width;
  else
    homogeneous_size = max_homogeneous_child_height;
  
  pack_front_size = 0;
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      guint size;
      
      if (!toolbar_content_visible (content, toolbar))
	continue;

      if (toolbar_content_is_homogeneous (content, toolbar))
	{
	  size = homogeneous_size;
	}
      else
	{
	  GtkRequisition requisition;
	  
	  toolbar_content_size_request (content, toolbar, &requisition);
	  
	  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
	    size = requisition.width;
	  else
	    size = requisition.height;
	}

      pack_front_size += size;
    }
  
  if (priv->show_arrow && priv->api_mode == NEW_API)
    {
      gtk_widget_size_request (priv->arrow_button, &arrow_requisition);
      
      if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
	long_req = arrow_requisition.width;
      else
	long_req = arrow_requisition.height;
      
      /* There is no point requesting space for the arrow if that would take
       * up more space than all the items combined
       */
      long_req = MIN (long_req, pack_front_size);
    }
  else
    {
      arrow_requisition.height = 0;
      arrow_requisition.width = 0;
      
      long_req = pack_front_size;
    }
  
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      requisition->width = long_req;
      requisition->height = MAX (max_child_height, arrow_requisition.height);
    }
  else
    {
      requisition->height = long_req;
      requisition->width = MAX (max_child_width, arrow_requisition.width);
    }
  
  /* Extra spacing */
  ipadding = get_internal_padding (toolbar);
  
  requisition->width += 2 * (ipadding + GTK_CONTAINER (toolbar)->border_width);
  requisition->height += 2 * (ipadding + GTK_CONTAINER (toolbar)->border_width);
  
  if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
    {
      requisition->width += 2 * widget->style->xthickness;
      requisition->height += 2 * widget->style->ythickness;
    }
  
  toolbar->button_maxw = max_homogeneous_child_width;
  toolbar->button_maxh = max_homogeneous_child_height;
}

static gint
position (gint from, gint to, gdouble elapsed)
{
  if (to > from)
    return MIN (from + SLIDE_SPEED * elapsed, to);
  else
    return MAX (from - SLIDE_SPEED * elapsed, to);
}

static void
compute_intermediate_allocation (Gtk24Toolbar          *toolbar,
				 const GtkAllocation *start,
				 const GtkAllocation *goal,
				 GtkAllocation       *intermediate)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  gdouble elapsed = g_timer_elapsed (priv->timer, NULL);
  
  intermediate->x = position (start->x, goal->x, elapsed);
  intermediate->y = position (start->y, goal->y, elapsed);
  intermediate->width =
    position (start->x + start->width, goal->x + goal->width, elapsed) - intermediate->x;
  intermediate->height =
    position (start->y + start->height, goal->y + goal->height, elapsed) - intermediate->y;
}

static void
fixup_allocation_for_rtl (gint           total_size,
			  GtkAllocation *allocation)
{
  allocation->x += (total_size - (2 * allocation->x + allocation->width));
}

static void
fixup_allocation_for_vertical (GtkAllocation *allocation)
{
  gint tmp;
  
  tmp = allocation->x;
  allocation->x = allocation->y;
  allocation->y = tmp;
  
  tmp = allocation->width;
  allocation->width = allocation->height;
  allocation->height = tmp;
}

static gint
get_item_size (Gtk24Toolbar     *toolbar,
	       ToolbarContent *content)
{
  GtkRequisition requisition;
  
  toolbar_content_size_request (content, toolbar, &requisition);
  
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      if (toolbar_content_is_homogeneous (content, toolbar))
	return toolbar->button_maxw;
      else
	return requisition.width;
    }
  else
    {
      if (toolbar_content_is_homogeneous (content, toolbar))
	return toolbar->button_maxh;
      else
	return requisition.height;
    }
}

static gboolean
slide_idle_handler (gpointer data)
{
  Gtk24Toolbar *toolbar = data;
  Gtk24ToolbarPrivate *priv;
  GList *list;
  
  GDK_THREADS_ENTER ();
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (priv->need_sync)
    {
      gdk_flush ();
      priv->need_sync = FALSE;
    }
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      ItemState state;
      GtkAllocation goal_allocation;
      GtkAllocation allocation;
      gboolean cont;

      state = toolbar_content_get_state (content);
      toolbar_content_get_goal_allocation (content, &goal_allocation);
      toolbar_content_get_allocation (content, &allocation);
      
      cont = FALSE;
      
      if (state == NOT_ALLOCATED)
	{
	  /* an unallocated item means that size allocate has to
	   * called at least once more
	   */
	  cont = TRUE;
	}

      /* An invisible item with a goal allocation of
       * 0 is already at its goal.
       */
      if ((state == NORMAL || state == OVERFLOWN) &&
	  ((goal_allocation.width != 0 &&
	    goal_allocation.height != 0) ||
	   toolbar_content_child_visible (content)))
	{
	  if ((goal_allocation.x != allocation.x ||
	       goal_allocation.y != allocation.y ||
	       goal_allocation.width != allocation.width ||
	       goal_allocation.height != allocation.height))
	    {
	      /* An item is not in its right position yet. Note
	       * that OVERFLOWN items do get an allocation in
	       * gtk24_toolbar_size_allocate(). This way you can see
	       * them slide back in when you drag an item off the
	       * toolbar.
	       */
	      cont = TRUE;
	    }
	}

      if (toolbar_content_is_placeholder (content) &&
	  toolbar_content_disappearing (content) &&
	  toolbar_content_child_visible (content))
	{
	  /* A disappearing placeholder is still visible.
	   */
	     
	  cont = TRUE;
	}
      
      if (cont)
	{
	  gtk_widget_queue_resize_no_redraw (GTK_WIDGET (toolbar));
	  
	  GDK_THREADS_LEAVE ();
	  return TRUE;
	}
    }
  
  priv->is_sliding = FALSE;
  priv->idle_id = 0;

  GDK_THREADS_LEAVE();
  return FALSE;
}

static gboolean
rect_within (GtkAllocation *a1,
	     GtkAllocation *a2)
{
  return (a1->x >= a2->x                         &&
	  a1->x + a1->width <= a2->x + a2->width &&
	  a1->y >= a2->y			 &&
	  a1->y + a1->height <= a2->y + a2->height);
}

static void
gtk24_toolbar_begin_sliding (Gtk24Toolbar *toolbar)
{
  GtkWidget *widget = GTK_WIDGET (toolbar);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  gint cur_x;
  gint cur_y;
  gint border_width;
  gboolean rtl;
  gboolean vertical;
  
  /* Start the sliding. This function copies the allocation of every
   * item into content->start_allocation. For items that haven't
   * been allocated yet, we calculate their position and save that
   * in start_allocatino along with zero width and zero height.
   */
  priv->is_sliding = TRUE;
  
  if (!priv->idle_id)
    priv->idle_id = g_idle_add (slide_idle_handler, toolbar);
  
  rtl = (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_RTL);
  vertical = (toolbar->orientation == GTK_ORIENTATION_VERTICAL);
  border_width = get_internal_padding (toolbar) + GTK_CONTAINER (toolbar)->border_width;
  
  if (rtl)
    {
      cur_x = widget->allocation.width - border_width - widget->style->xthickness;
      cur_y = widget->allocation.height - border_width - widget->style->ythickness;
    }
  else
    {
      cur_x = border_width + widget->style->xthickness;
      cur_y = border_width + widget->style->ythickness;
    }
  
  cur_x += widget->allocation.x;
  cur_y += widget->allocation.y;
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      GtkAllocation new_start_allocation;
      GtkAllocation item_allocation;
      ItemState state;
      
      state = toolbar_content_get_state (content);
      toolbar_content_get_allocation (content, &item_allocation);
      
      if ((state == NORMAL &&
	   rect_within (&item_allocation, &(widget->allocation))) ||
	  state == OVERFLOWN)
	{
	  new_start_allocation = item_allocation;
	}
      else
	{
	  new_start_allocation.x = cur_x;
	  new_start_allocation.y = cur_y;
	  
	  if (vertical)
	    {
	      new_start_allocation.width = widget->allocation.width -
		2 * border_width - 2 * widget->style->xthickness;
	      new_start_allocation.height = 0;
	    }
	  else
	    {
	      new_start_allocation.width = 0;
	      new_start_allocation.height = widget->allocation.height -
		2 * border_width - 2 * widget->style->ythickness;
	    }
	}
      
      if (vertical)
	cur_y = new_start_allocation.y + new_start_allocation.height;
      else if (rtl)
	cur_x = new_start_allocation.x;
      else
	cur_x = new_start_allocation.x + new_start_allocation.width;
      
      toolbar_content_set_start_allocation (content, &new_start_allocation);
    }

  /* This resize will run before the first idle handler. This
   * will make sure that items get the right goal allocatiuon
   * so that the idle handler will not immediately return
   * FALSE
   */
  gtk_widget_queue_resize_no_redraw (GTK_WIDGET (toolbar));
  g_timer_reset (priv->timer);
}

static void
gtk24_toolbar_stop_sliding (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (priv->is_sliding)
    {
      GList *list;
      
      priv->is_sliding = FALSE;
      
      if (priv->idle_id)
	{
	  g_source_remove (priv->idle_id);
	  priv->idle_id = 0;
	}
      
      list = priv->content;
      while (list)
	{
	  ToolbarContent *content = list->data;
	  list = list->next;

	  if (toolbar_content_is_placeholder (content))
	    {
	      toolbar_content_remove (content, toolbar);
	      toolbar_content_free (content);
	    }
	}
      
      gtk_widget_queue_resize_no_redraw (GTK_WIDGET (toolbar));
    }
}

static void
gtk24_toolbar_size_allocate (GtkWidget     *widget,
			   GtkAllocation *allocation)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GtkAllocation *allocations;
  ItemState *new_states;
  GtkAllocation arrow_allocation;
  gint arrow_size;
  gint size, pos, short_size;
  GList *list;
  gint i;
  gboolean need_arrow;
  gint n_expand_items;
  gint border_width;
  gint available_size;
  gint n_items;
  gint needed_size;
  GtkRequisition arrow_requisition;
  gboolean overflowing;
  gboolean size_changed;
  gdouble elapsed;
  GtkAllocation item_area;
  
  size_changed = FALSE;
  if (widget->allocation.x != allocation->x		||
      widget->allocation.y != allocation->y		||
      widget->allocation.width != allocation->width	||
      widget->allocation.height != allocation->height)
    {
      size_changed = TRUE;
    }
  
  if (size_changed)
    gtk24_toolbar_stop_sliding (toolbar);
  
  widget->allocation = *allocation;
  
  border_width = GTK_CONTAINER (toolbar)->border_width;
  
  if (GTK_WIDGET_REALIZED (widget))
    {
      gdk_window_move_resize (priv->event_window,
                              allocation->x + border_width,
                              allocation->y + border_width,
                              allocation->width - border_width * 2,
                              allocation->height - border_width * 2);
    }
  
  border_width += get_internal_padding (toolbar);
  
  gtk_widget_get_child_requisition (GTK_WIDGET (priv->arrow_button),
				    &arrow_requisition);
  
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      available_size = size = allocation->width - 2 * border_width;
      short_size = allocation->height - 2 * border_width;
      arrow_size = arrow_requisition.width;
      
      if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
	{
	  available_size -= 2 * widget->style->xthickness;
	  short_size -= 2 * widget->style->ythickness;
	}
    }
  else
    {
      available_size = size = allocation->height - 2 * border_width;
      short_size = allocation->width - 2 * border_width;
      arrow_size = arrow_requisition.height;
      
      if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
	{
	  available_size -= 2 * widget->style->ythickness;
	  short_size -= 2 * widget->style->xthickness;
	}
    }
  
  n_items = g_list_length (priv->content);
  allocations = g_new0 (GtkAllocation, n_items);
  new_states = g_new0 (ItemState, n_items);
  
  needed_size = 0;
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      if (toolbar_content_visible (content, toolbar))
	needed_size += get_item_size (toolbar, content);
    }
  
  need_arrow = (needed_size > available_size) && priv->show_arrow && priv->api_mode == NEW_API;
  
  if (need_arrow)
    size = available_size - arrow_size;
  else
    size = available_size;
  
  /* calculate widths of items */
  overflowing = FALSE;
  for (list = priv->content, i = 0; list != NULL; list = list->next, ++i)
    {
      ToolbarContent *content = list->data;
      gint item_size;
      
      if (!toolbar_content_visible (content, toolbar))
	{
	  new_states[i] = HIDDEN;
	  continue;
	}
      
      item_size = get_item_size (toolbar, content);
      if (item_size <= size && !overflowing)
	{
	  size -= item_size;
	  allocations[i].width = item_size;
	  new_states[i] = NORMAL;
	}
      else
	{
	  overflowing = TRUE;
	  new_states[i] = OVERFLOWN;
	  allocations[i].width = item_size;
	}
    }
  
  /* calculate width of arrow */  
  if (need_arrow)
    {
      arrow_allocation.width = arrow_size;
      arrow_allocation.height = short_size;
    }
  
  /* expand expandable items */
  
  /* We don't expand when there is an overflow menu, because that leads to
   * weird jumps when items get moved to the overflow menu and the expanding
   * items suddenly get a lot of extra space
   */
  if (!overflowing)
    {
      n_expand_items = 0;
      for (i = 0, list = priv->content; list != NULL; list = list->next, ++i)
	{
	  ToolbarContent *content = list->data;
	  
	  if (toolbar_content_get_expand (content) && new_states[i] == NORMAL)
	    n_expand_items++;
	}
      
      for (list = priv->content, i = 0; list != NULL; list = list->next, ++i)
	{
	  ToolbarContent *content = list->data;
	  
	  if (toolbar_content_get_expand (content) && new_states[i] == NORMAL)
	    {
	      gint extra = size / n_expand_items;
	      if (size % n_expand_items != 0)
		extra++;
	      
	      allocations[i].width += extra;
	      size -= extra;
	      n_expand_items--;
	    }
	}
      
      g_assert (n_expand_items == 0);
    }
  
  /* position items */
  pos = border_width;
  for (list = priv->content, i = 0; list != NULL; list = list->next, ++i)
    {
      /* both NORMAL and OVERFLOWN items get a position. This ensures
       * that sliding will work for OVERFLOWN items too
       */
      if (new_states[i] == NORMAL ||
	  new_states[i] == OVERFLOWN)
	{
	  allocations[i].x = pos;
	  allocations[i].y = border_width;
	  allocations[i].height = short_size;
	  
	  pos += allocations[i].width;
	}
    }
  
  /* position arrow */
  if (need_arrow)
    {
      arrow_allocation.x = available_size - border_width - arrow_allocation.width;
      arrow_allocation.y = border_width;
    }
  
  item_area.x = border_width;
  item_area.y = border_width;
  item_area.width = available_size - (need_arrow? arrow_size : 0);
  item_area.height = short_size;

  /* fix up allocations in the vertical or RTL cases */
  if (toolbar->orientation == GTK_ORIENTATION_VERTICAL)
    {
      for (i = 0; i < n_items; ++i)
	fixup_allocation_for_vertical (&(allocations[i]));
      
      if (need_arrow)
	fixup_allocation_for_vertical (&arrow_allocation);

      fixup_allocation_for_vertical (&item_area);
    }
  else if (gtk_widget_get_direction (GTK_WIDGET (toolbar)) == GTK_TEXT_DIR_RTL)
    {
      for (i = 0; i < n_items; ++i)
	fixup_allocation_for_rtl (available_size, &(allocations[i]));
      
      if (need_arrow)
	fixup_allocation_for_rtl (available_size, &arrow_allocation);

      fixup_allocation_for_rtl (available_size, &item_area);
    }
  
  /* translate the items by allocation->(x,y) */
  for (i = 0; i < n_items; ++i)
    {
      allocations[i].x += allocation->x;
      allocations[i].y += allocation->y;
      
      if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
	{
	  allocations[i].x += widget->style->xthickness;
	  allocations[i].y += widget->style->ythickness;
	}
    }
  
  if (need_arrow)
    {
      arrow_allocation.x += allocation->x;
      arrow_allocation.y += allocation->y;
      
      if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
	{
	  arrow_allocation.x += widget->style->xthickness;
	  arrow_allocation.y += widget->style->ythickness;
	}
    }

  item_area.x += allocation->x;
  item_area.y += allocation->y;
  if (get_shadow_type (toolbar) != GTK_SHADOW_NONE)
    {
      item_area.x += widget->style->xthickness;
      item_area.y += widget->style->ythickness;
    }

  /* did anything change? */
  for (list = priv->content, i = 0; list != NULL; list = list->next, i++)
    {
      ToolbarContent *content = list->data;
      
      if (toolbar_content_get_state (content) == NORMAL &&
	  new_states[i] != NORMAL)
	{
	  /* an item disappeared, begin sliding */
	  if (!size_changed && priv->api_mode == NEW_API)
	    gtk24_toolbar_begin_sliding (toolbar);
	}
    }
  
  /* finally allocate the items */
  if (priv->is_sliding)
    {
      for (list = priv->content, i = 0; list != NULL; list = list->next, i++)
	{
	  ToolbarContent *content = list->data;
	  
	  toolbar_content_set_goal_allocation (content, &(allocations[i]));
	}
    }

  elapsed = g_timer_elapsed (priv->timer, NULL);
  for (list = priv->content, i = 0; list != NULL; list = list->next, ++i)
    {
      ToolbarContent *content = list->data;

      if (new_states[i] == OVERFLOWN ||
	  new_states[i] == NORMAL)
	{
	  GtkAllocation alloc;
	  GtkAllocation start_allocation;
	  GtkAllocation goal_allocation;

	  if (priv->is_sliding)
	    {
	      toolbar_content_get_start_allocation (content, &start_allocation);
	      toolbar_content_get_goal_allocation (content, &goal_allocation);
	      
	      compute_intermediate_allocation (toolbar,
					       &start_allocation,
					       &goal_allocation,
					       &alloc);

	      priv->need_sync = TRUE;
	    }
	  else
	    {
	      alloc = allocations[i];
	    }

	  if (alloc.width == 0 || alloc.height == 0)
	    {
	      toolbar_content_set_child_visible (content, toolbar, FALSE);
	    }
	  else
	    {
	      if (!rect_within (&alloc, &item_area))
		{
		  toolbar_content_set_child_visible (content, toolbar, FALSE);
		  toolbar_content_size_allocate (content, &alloc);
		}
	      else
		{
		  toolbar_content_set_child_visible (content, toolbar, TRUE);
		  toolbar_content_size_allocate (content, &alloc);
		}
	    }
	}
      else
	{
	  toolbar_content_set_child_visible (content, toolbar, FALSE);
	}
	  
      toolbar_content_set_state (content, new_states[i]);
    }
  
  if (need_arrow)
    {
      gtk_widget_size_allocate (GTK_WIDGET (priv->arrow_button),
				&arrow_allocation);
      gtk_widget_show (GTK_WIDGET (priv->arrow_button));
    }
  else
    {
      gtk_widget_hide (GTK_WIDGET (priv->arrow_button));
    }
  
  g_free (allocations);
  g_free (new_states);
}

static void
gtk24_toolbar_update_button_relief (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  gtk24_toolbar_reconfigured (toolbar);
  
  gtk_button_set_relief (GTK_BUTTON (priv->arrow_button), get_button_relief (toolbar));
}

static void
gtk24_toolbar_style_set (GtkWidget *widget,
		       GtkStyle  *prev_style)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  
  priv->max_homogeneous_pixels = -1;
  
  if (GTK_WIDGET_REALIZED (widget))
    gtk_style_set_background (widget->style, widget->window, widget->state);
  
  if (prev_style)
    gtk24_toolbar_update_button_relief (GTK24_TOOLBAR (widget));
}

static GList *
gtk24_toolbar_list_children_in_focus_order (Gtk24Toolbar       *toolbar,
					  GtkDirectionType  dir)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *result = NULL;
  GList *list;
  gboolean rtl;
  
  /* generate list of children in reverse logical order */
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      GtkWidget *widget;
      
      widget = toolbar_content_get_widget (content);
      
      if (widget)
	result = g_list_prepend (result, widget);
    }
  
  result = g_list_prepend (result, priv->arrow_button);
  
  rtl = (gtk_widget_get_direction (GTK_WIDGET (toolbar)) == GTK_TEXT_DIR_RTL);
  
  /* move in logical order when
   *
   *	- dir is TAB_FORWARD
   *
   *	- in RTL mode and moving left or up
   *
   *    - in LTR mode and moving right or down
   */
  if (dir == GTK_DIR_TAB_FORWARD                                        ||
      (rtl  && (dir == GTK_DIR_UP   || dir == GTK_DIR_LEFT))		||
      (!rtl && (dir == GTK_DIR_DOWN || dir == GTK_DIR_RIGHT)))
    {
      result = g_list_reverse (result);
    }
  
  return result;
}

static gboolean
gtk24_toolbar_focus_home_or_end (Gtk24Toolbar *toolbar,
			       gboolean    focus_home)
{
  GList *children, *list;
  GtkDirectionType dir = focus_home? GTK_DIR_RIGHT : GTK_DIR_LEFT;
  
  children = gtk24_toolbar_list_children_in_focus_order (toolbar, dir);
  
  if (gtk_widget_get_direction (GTK_WIDGET (toolbar)) == GTK_TEXT_DIR_RTL)
    {
      children = g_list_reverse (children);
      
      dir = (dir == GTK_DIR_RIGHT)? GTK_DIR_LEFT : GTK_DIR_RIGHT;
    }
  
  for (list = children; list != NULL; list = list->next)
    {
      GtkWidget *child = list->data;
      
      if (GTK_CONTAINER (toolbar)->focus_child == child)
	break;
      
      if (GTK_WIDGET_MAPPED (child) && gtk_widget_child_focus (child, dir))
	break;
    }
  
  g_list_free (children);
  
  return TRUE;
}   

/* Keybinding handler. This function is called when the user presses
 * Ctrl TAB or an arrow key.
 */
static gboolean
gtk24_toolbar_move_focus (Gtk24Toolbar       *toolbar,
			GtkDirectionType  dir)
{
  GList *list;
  gboolean try_focus = FALSE;
  GList *children;
  GtkContainer *container = GTK_CONTAINER (toolbar);
  
  if (container->focus_child &&
      gtk_widget_child_focus (container->focus_child, dir))
    {
      return TRUE;
    }
  
  children = gtk24_toolbar_list_children_in_focus_order (toolbar, dir);
  
  for (list = children; list != NULL; list = list->next)
    {
      GtkWidget *child = list->data;
      
      if (try_focus && GTK_WIDGET_MAPPED (child) && gtk_widget_child_focus (child, dir))
	break;
      
      if (child == GTK_CONTAINER (toolbar)->focus_child)
	try_focus = TRUE;
    }
  
  g_list_free (children);
  
  return FALSE;
}

/* The focus handler for the toolbar. It called when the user presses
 * TAB or otherwise tries to focus the toolbar.
 */
static gboolean
gtk24_toolbar_focus (GtkWidget        *widget,
		   GtkDirectionType  dir)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  GList *children, *list;
  
  /* if focus is already somewhere inside the toolbar then return FALSE.
   * The only way focus can stay inside the toolbar is when the user presses
   * arrow keys or Ctrl TAB (both of which are handled by the
   * gtk24_toolbar_move_focus() keybinding function.
   */
  if (GTK_CONTAINER (widget)->focus_child)
    return FALSE;
  
  children = gtk24_toolbar_list_children_in_focus_order (toolbar, dir);
  
  for (list = children; list != NULL; list = list->next)
    {
      GtkWidget *child = list->data;
      
      if (GTK_WIDGET_MAPPED (child) && gtk_widget_child_focus (child, dir))
	return TRUE;
    }
  
  g_list_free (children);
  
  return FALSE;
}

static void
style_change_notify (Gtk24Toolbar *toolbar)
{
  if (!toolbar->style_set)
    {
      /* pretend it was set, then unset, thus reverting to new default */
      toolbar->style_set = TRUE; 
      gtk24_toolbar_unset_style (toolbar);
    }
}

static void
icon_size_change_notify (Gtk24Toolbar *toolbar)
{ 
  if (!toolbar->icon_size_set)
    {
      /* pretend it was set, then unset, thus reverting to new default */
      toolbar->icon_size_set = TRUE; 
      gtk24_toolbar_unset_icon_size (toolbar);
    }
}

static GtkSettings *
toolbar_get_settings (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  return priv->settings;
}

static void
gtk24_toolbar_screen_changed (GtkWidget *widget,
			    GdkScreen *previous_screen)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (widget);
  GtkSettings *old_settings = toolbar_get_settings (toolbar);
  GtkSettings *settings;
  
  if (gtk_widget_has_screen (GTK_WIDGET (toolbar)))
    settings = gtk_widget_get_settings (GTK_WIDGET (toolbar));
  else
    settings = NULL;
  
  if (settings == old_settings)
    return;
  
  if (old_settings)
    {
      g_signal_handler_disconnect (old_settings, toolbar->style_set_connection);
      g_signal_handler_disconnect (old_settings, toolbar->icon_size_connection);
      
      g_object_unref (old_settings);
    }
  
  if (settings)
    {
      toolbar->style_set_connection =
	g_signal_connect_swapped (settings,
				  "notify::gtk-toolbar-style",
				  G_CALLBACK (style_change_notify),
				  toolbar);
      toolbar->icon_size_connection =
	g_signal_connect_swapped (settings,
				  "notify::gtk-toolbar-icon-size",
				  G_CALLBACK (icon_size_change_notify),
				  toolbar);
      
      g_object_ref (settings);
      priv->settings = settings;
    }
  else
    priv->settings = NULL;
  
  style_change_notify (toolbar);
  icon_size_change_notify (toolbar);
}

static int
find_drop_index (Gtk24Toolbar *toolbar,
		 gint        x,
		 gint        y)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *interesting_content;
  GList *list;
  GtkOrientation orientation;
  GtkTextDirection direction;
  gint best_distance = G_MAXINT;
  gint distance;
  gint cursor;
  gint pos;
  ToolbarContent *best_content;
  GtkAllocation allocation;
  
  /* list items we care about wrt. drag and drop */
  interesting_content = NULL;
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      if (toolbar_content_get_state (content) == NORMAL)
	interesting_content = g_list_prepend (interesting_content, content);
    }
  interesting_content = g_list_reverse (interesting_content);
  
  if (!interesting_content)
    return 0;
  
  orientation = toolbar->orientation;
  direction = gtk_widget_get_direction (GTK_WIDGET (toolbar));
  
  /* distance to first interesting item */
  best_content = interesting_content->data;
  toolbar_content_get_allocation (best_content, &allocation);
  
  if (orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      cursor = x;
      
      if (direction == GTK_TEXT_DIR_LTR)
	pos = allocation.x;
      else
	pos = allocation.x + allocation.width;
    }
  else
    {
      cursor = y;
      pos = allocation.y;
    }
  
  best_content = NULL;
  best_distance = ABS (pos - cursor);
  
  /* distance to far end of each item */
  for (list = interesting_content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      toolbar_content_get_allocation (content, &allocation);
      
      if (orientation == GTK_ORIENTATION_HORIZONTAL)
	{
	  if (direction == GTK_TEXT_DIR_LTR)
	    pos = allocation.x + allocation.width;
	  else
	    pos = allocation.x;
	}
      else
	{
	  pos = allocation.y + allocation.height;
	}
      
      distance = ABS (pos - cursor);
      
      if (distance < best_distance)
	{
	  best_distance = distance;
	  best_content = content;
	}
    }
  
  g_list_free (interesting_content);
  
  if (!best_content)
    return 0;
  else
    return g_list_index (priv->content, best_content) + 1;
}

static void
reset_all_placeholders (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      if (toolbar_content_is_placeholder (content))
	toolbar_content_set_disappearing (content, TRUE);
    }
}

static gint
physical_to_logical (Gtk24Toolbar *toolbar,
		     gint        physical)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  int logical;
  
  g_assert (physical >= 0);
  
  logical = 0;
  for (list = priv->content; list && physical > 0; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      if (!toolbar_content_is_placeholder (content))
	logical++;
      physical--;
    }
  
  g_assert (physical == 0);
  
  return logical;
}

static gint
logical_to_physical (Gtk24Toolbar *toolbar,
		     gint        logical)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  gint physical;
  
  g_assert (logical >= 0);
  
  physical = 0;
  for (list = priv->content; list; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      if (!toolbar_content_is_placeholder (content))
	{
	  if (logical == 0)
	    break;
	  logical--;
	}
      
      physical++;
    }
  
  g_assert (logical == 0);
  
  return physical;
}

/**
 * gtk24_toolbar_set_drop_highlight_item:
 * @toolbar: a #GtkToolbar
 * @tool_item: a #GtkToolItem, or %NULL to turn of highlighting
 * @index: a position on @toolbar
 * 
 * Highlights @toolbar to give an idea of what it would look like
 * if @item was added to @toolbar at position indicated by @index. If @item
 * is %NULL, highlighting is turned off. In that case @index is ignored.
 *
 * The @tool_item passed to this function must not be part of any widget
 * hierarchy. When an item is set as drop highlight item it can not
 * added to any widget hierarchy or used as highlight item for another
 * toolbar.
 * 
 * Since: 2.4
 **/
void
gtk24_toolbar_set_drop_highlight_item (Gtk24Toolbar  *toolbar,
				     GtkToolItem *tool_item,
				     gint         index)
{
  ToolbarContent *content;
  Gtk24ToolbarPrivate *priv;
  gint n_items;
  GtkRequisition requisition;
  GtkRequisition old_requisition;
  gboolean restart_sliding;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  g_return_if_fail (tool_item == NULL || GTK_IS_TOOL_ITEM (tool_item));
  
  gtk24_toolbar_check_new_api (toolbar);
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (!tool_item)
    {
      if (priv->highlight_tool_item)
	{
	  gtk_widget_unparent (GTK_WIDGET (priv->highlight_tool_item));
	  g_object_unref (priv->highlight_tool_item);
	  priv->highlight_tool_item = NULL;
	}
      
      reset_all_placeholders (toolbar);
      gtk24_toolbar_begin_sliding (toolbar);
      return;
    }
  
  n_items = gtk24_toolbar_get_n_items (toolbar);
  if (index < 0 || index > n_items)
    index = n_items;
  
  if (tool_item != priv->highlight_tool_item)
    {
      if (priv->highlight_tool_item)
	g_object_unref (priv->highlight_tool_item);
      
      g_object_ref (tool_item);
      gtk_object_sink (GTK_OBJECT (tool_item));
      
      priv->highlight_tool_item = tool_item;
      
      gtk_widget_set_parent (GTK_WIDGET (priv->highlight_tool_item),
			     GTK_WIDGET (toolbar));
    }
  
  index = logical_to_physical (toolbar, index);
  
  content = g_list_nth_data (priv->content, index);
  
  if (index > 0)
    {
      ToolbarContent *prev_content;
      
      prev_content = g_list_nth_data (priv->content, index - 1);
      
      if (prev_content && toolbar_content_is_placeholder (prev_content))
	content = prev_content;
    }
  
  if (!content || !toolbar_content_is_placeholder (content))
    {
      GtkWidget *placeholder;
      
      placeholder = GTK_WIDGET (gtk_separator_tool_item_new ());

      content = toolbar_content_new_tool_item (toolbar,
					       GTK_TOOL_ITEM (placeholder),
					       TRUE, index);
      gtk_widget_show (placeholder);
    }
  
  g_assert (content);
  g_assert (toolbar_content_is_placeholder (content));
  
  gtk_widget_size_request (GTK_WIDGET (priv->highlight_tool_item),
			   &requisition);

  
  restart_sliding = FALSE;
  toolbar_content_size_request (content, toolbar, &old_requisition);
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      requisition.height = -1;
      if (requisition.width != old_requisition.width)
	restart_sliding = TRUE;
    }
  else
    {
      requisition.width = -1;
      if (requisition.height != old_requisition.height)
	restart_sliding = TRUE;
    }

  if (toolbar_content_disappearing (content))
    restart_sliding = TRUE;
  
  reset_all_placeholders (toolbar);
  toolbar_content_set_disappearing (content, FALSE);
  
  toolbar_content_set_size_request (content,
				    requisition.width, requisition.height);
  
  if (restart_sliding)
    gtk24_toolbar_begin_sliding (toolbar);
}

static void
gtk24_toolbar_get_child_property (GtkContainer *container,
				GtkWidget    *child,
				guint         property_id,
				GValue       *value,
				GParamSpec   *pspec)
{
  GtkToolItem *item = GTK_TOOL_ITEM (child);
  
  switch (property_id)
    {
    case CHILD_PROP_HOMOGENEOUS:
      g_value_set_boolean (value, gtk_tool_item_get_homogeneous (item));
      break;
      
    case CHILD_PROP_EXPAND:
      g_value_set_boolean (value, gtk_tool_item_get_expand (item));
      break;
      
    default:
      GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec);
      break;
    }
}

static void
gtk24_toolbar_set_child_property (GtkContainer *container,
				GtkWidget    *child,
				guint         property_id,
				const GValue *value,
				GParamSpec   *pspec)
{
  switch (property_id)
    {
    case CHILD_PROP_HOMOGENEOUS:
      gtk_tool_item_set_homogeneous (GTK_TOOL_ITEM (child), g_value_get_boolean (value));
      break;
      
    case CHILD_PROP_EXPAND:
      gtk_tool_item_set_expand (GTK_TOOL_ITEM (child), g_value_get_boolean (value));
      break;
      
    default:
      GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec);
      break;
    }
}

static void
gtk24_toolbar_show_all (GtkWidget *widget)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  GList *list;

  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      toolbar_content_show_all (content);
    }
  
  gtk_widget_show (widget);
}

static void
gtk24_toolbar_hide_all (GtkWidget *widget)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (widget);
  GList *list;

  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      toolbar_content_hide_all (content);
    }

  gtk_widget_hide (widget);
}

static void
gtk24_toolbar_add (GtkContainer *container,
		 GtkWidget    *widget)
{
  Gtk24Toolbar *toolbar;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (container));
  g_return_if_fail (widget != NULL);
  
  toolbar = GTK24_TOOLBAR (container);
  
  if (GTK_IS_TOOL_ITEM (widget))
    gtk24_toolbar_insert (toolbar, GTK_TOOL_ITEM (widget), -1);
  else
    gtk24_toolbar_append_widget (toolbar, widget, NULL, NULL);
}

static void
gtk24_toolbar_remove (GtkContainer *container,
		    GtkWidget    *widget)
{
  Gtk24Toolbar *toolbar;
  Gtk24ToolbarPrivate *priv;
  ToolbarContent *content_to_remove;
  GList *list;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (container));
  g_return_if_fail (GTK_IS_WIDGET (widget));
  
  toolbar = GTK24_TOOLBAR (container);
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  content_to_remove = NULL;
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      GtkWidget *child;
      
      child = toolbar_content_get_widget (content);
      if (child && child == widget)
	{
	  content_to_remove = content;
	  break;
	}
    }
  
  g_return_if_fail (content_to_remove != NULL);
  
  toolbar_content_remove (content_to_remove, toolbar);
  toolbar_content_free (content_to_remove);
}

static void
gtk24_toolbar_forall (GtkContainer *container,
		    gboolean	  include_internals,
		    GtkCallback   callback,
		    gpointer      callback_data)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (container);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  
  g_return_if_fail (callback != NULL);
  
  list = priv->content;
  while (list)
    {
      ToolbarContent *content = list->data;
      GList *next = list->next;
      
      if (include_internals || !toolbar_content_is_placeholder (content))
	{
	  GtkWidget *child = toolbar_content_get_widget (content);
	  
	  if (child)
	    (*callback) (child, callback_data);
	}
      
      list = next;
    }
  
  if (include_internals)
    (* callback) (priv->arrow_button, callback_data);
}

static GType
gtk24_toolbar_child_type (GtkContainer *container)
{
  return GTK_TYPE_TOOL_ITEM;
}

static void
gtk24_toolbar_reconfigured (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  
  list = priv->content;
  while (list)
    {
      ToolbarContent *content = list->data;
      GList *next = list->next;
      
      toolbar_content_toolbar_reconfigured (content, toolbar);
      
      list = next;
    }
}

static void
gtk24_toolbar_orientation_changed (Gtk24Toolbar    *toolbar,
				 GtkOrientation orientation)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  if (toolbar->orientation != orientation)
    {
      toolbar->orientation = orientation;
      
      if (orientation == GTK_ORIENTATION_HORIZONTAL)
	gtk_arrow_set (GTK_ARROW (priv->arrow), GTK_ARROW_DOWN, GTK_SHADOW_NONE);
      else
	gtk_arrow_set (GTK_ARROW (priv->arrow), GTK_ARROW_RIGHT, GTK_SHADOW_NONE);
      
      gtk24_toolbar_reconfigured (toolbar);
      
      gtk_widget_queue_resize (GTK_WIDGET (toolbar));
      g_object_notify (G_OBJECT (toolbar), "orientation");
    }
}

static void
gtk24_toolbar_real_style_changed (Gtk24Toolbar     *toolbar,
				GtkToolbarStyle style)
{
  if (toolbar->style != style)
    {
      toolbar->style = style;
      
      gtk24_toolbar_reconfigured (toolbar);
      
      gtk_widget_queue_resize (GTK_WIDGET (toolbar));
      g_object_notify (G_OBJECT (toolbar), "toolbar_style");
    }
}

static void
menu_position_func (GtkMenu  *menu,
		    gint     *x,
		    gint     *y,
		    gboolean *push_in,
		    gpointer  user_data)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (user_data);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GtkRequisition req;
  GtkRequisition menu_req;
  
  gdk_window_get_origin (GTK_BUTTON (priv->arrow_button)->event_window, x, y);
  gtk_widget_size_request (priv->arrow_button, &req);
  gtk_widget_size_request (GTK_WIDGET (menu), &menu_req);
  
  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      *y += priv->arrow_button->allocation.height;
      if (gtk_widget_get_direction (GTK_WIDGET (toolbar)) == GTK_TEXT_DIR_LTR) 
	*x += priv->arrow_button->allocation.width - req.width;
      else 
	*x += req.width - menu_req.width;
    }
  else 
    {
      if (gtk_widget_get_direction (GTK_WIDGET (toolbar)) == GTK_TEXT_DIR_LTR) 
	*x += priv->arrow_button->allocation.width;
      else 
	*x -= menu_req.width;
      *y += priv->arrow_button->allocation.height - req.height;      
    }
  
  *push_in = TRUE;
}

static void
menu_deactivated (GtkWidget  *menu,
		  Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->arrow_button), FALSE);
}

static void
menu_detached (GtkWidget  *toolbar,
	       GtkMenu    *menu)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  priv->menu = NULL;
}

static void
remove_item (GtkWidget *menu_item,
	     gpointer   data)
{
  gtk_container_remove (GTK_CONTAINER (menu_item->parent), menu_item);
}

static void
show_menu (Gtk24Toolbar     *toolbar,
	   GdkEventButton *event)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  GList *list;
  
  if (priv->menu)
    {
      gtk_container_foreach (GTK_CONTAINER (priv->menu), remove_item, NULL);
      gtk_widget_destroy (GTK_WIDGET (priv->menu));
    }

  priv->menu = GTK_MENU (gtk_menu_new ());
  gtk_menu_attach_to_widget (priv->menu,
			     GTK_WIDGET (toolbar),
			     menu_detached);
  g_signal_connect (priv->menu, "deactivate", G_CALLBACK (menu_deactivated), toolbar);

  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      
      if (toolbar_content_get_state (content) == OVERFLOWN &&
	  !toolbar_content_is_placeholder (content))
	{
	  GtkWidget *menu_item = toolbar_content_retrieve_menu_item (content);
	  
	  if (menu_item)
	    {
	      g_assert (GTK_IS_MENU_ITEM (menu_item));
	      gtk_menu_shell_append (GTK_MENU_SHELL (priv->menu), menu_item);
	    }
	}
    }

  gtk_widget_show_all (GTK_WIDGET (priv->menu));

  gtk_menu_popup (priv->menu, NULL, NULL,
		  menu_position_func, toolbar,
		  event? event->button : 0,
		  event? event->time : gtk_get_current_event_time());
}

static void
gtk24_toolbar_arrow_button_clicked (GtkWidget  *button,
				  Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);  
  
  if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->arrow_button)) &&
      (!priv->menu || !GTK_WIDGET_VISIBLE (GTK_WIDGET (priv->menu))))
    {
      /* We only get here when the button is clicked with the keybaord,
       * because mouse button presses result in the menu being shown so
       * that priv->menu would be non-NULL and visible.
       */
      show_menu (toolbar, NULL);
      gtk_menu_shell_select_first (GTK_MENU_SHELL (priv->menu), FALSE);
    }
}

static gboolean
gtk24_toolbar_arrow_button_press (GtkWidget      *button,
				GdkEventButton *event,
				Gtk24Toolbar     *toolbar)
{
  show_menu (toolbar, event);
  gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (button), TRUE);
  
  return TRUE;
}

static gboolean
gtk24_toolbar_button_press (GtkWidget      *toolbar,
    			  GdkEventButton *event)
{
  if (event->button == 3)
    {
      gboolean return_value;
      
      g_signal_emit (toolbar, toolbar_signals[POPUP_CONTEXT_MENU], 0,
		     (int)event->x_root, (int)event->y_root, event->button,
		     &return_value);
      
      return return_value;
    }
  
  return FALSE;
}

static gboolean
gtk24_toolbar_popup_menu (GtkWidget *toolbar)
{
  gboolean return_value;
  /* This function is the handler for the "popup menu" keybinding,
   * ie., it is called when the user presses Shift F10
   */
  g_signal_emit (toolbar, toolbar_signals[POPUP_CONTEXT_MENU], 0,
		 -1, -1, -1, &return_value);
  
  return return_value;
}

/**
 * gtk24_toolbar_new:
 * 
 * Creates a new toolbar. 
 
 * Return Value: the newly-created toolbar.
 **/
GtkWidget *
gtk24_toolbar_new (void)
{
  Gtk24Toolbar *toolbar;
  
  toolbar = g_object_new (GTK24_TYPE_TOOLBAR, NULL);
  
  return GTK_WIDGET (toolbar);
}

/**
 * gtk24_toolbar_insert:
 * @toolbar: a #GtkToolbar
 * @item: a #GtkToolItem
 * @pos: the position of the new item
 *
 * Insert a #GtkToolItem into the toolbar at position @pos. If @pos is
 * 0 the item is prepended to the start of the toolbar. If @pos is
 * negative, the item is appended to the end of the toolbar.
 *
 * Since: 2.4
 **/
void
gtk24_toolbar_insert (Gtk24Toolbar  *toolbar,
		    GtkToolItem *item,
		    gint         pos)
{
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  g_return_if_fail (GTK_IS_TOOL_ITEM (item));
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return;
  
  if (pos >= 0)
    pos = logical_to_physical (toolbar, pos);

  toolbar_content_new_tool_item (toolbar, item, FALSE, pos);
}

/**
 * gtk24_toolbar_get_item_index:
 * @toolbar: a #GtkToolbar
 * @item: a #GtkToolItem that is a child of @toolbar
 * 
 * Returns the position of @item on the toolbar, starting from 0.
 * It is an error if @item is not a child of the toolbar.
 * 
 * Return value: the position of item on the toolbar.
 * 
 * Since: 2.4
 **/
gint
gtk24_toolbar_get_item_index (Gtk24Toolbar  *toolbar,
			    GtkToolItem *item)
{
  Gtk24ToolbarPrivate *priv;
  GList *list;
  int n;
  
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), -1);
  g_return_val_if_fail (GTK_IS_TOOL_ITEM (item), -1);
  g_return_val_if_fail (GTK_WIDGET (item)->parent == GTK_WIDGET (toolbar), -1);
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return -1;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  n = 0;
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;
      GtkWidget *widget;
      
      widget = toolbar_content_get_widget (content);
      
      if (item == GTK_TOOL_ITEM (widget))
	break;
      
      ++n;
    }
  
  return physical_to_logical (toolbar, n);
}

/**
 * gtk24_toolbar_set_orientation:
 * @toolbar: a #GtkToolbar.
 * @orientation: a new #GtkOrientation.
 * 
 * Sets whether a toolbar should appear horizontally or vertically.
 **/
void
gtk24_toolbar_set_orientation (Gtk24Toolbar     *toolbar,
			     GtkOrientation  orientation)
{
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  g_signal_emit (toolbar, toolbar_signals[ORIENTATION_CHANGED], 0, orientation);
}

/**
 * gtk24_toolbar_get_orientation:
 * @toolbar: a #GtkToolbar
 * 
 * Retrieves the current orientation of the toolbar. See
 * gtk24_toolbar_set_orientation().
 *
 * Return value: the orientation
 **/
GtkOrientation
gtk24_toolbar_get_orientation (Gtk24Toolbar *toolbar)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), GTK_ORIENTATION_HORIZONTAL);
  
  return toolbar->orientation;
}

/**
 * gtk24_toolbar_set_style:
 * @toolbar: a #GtkToolbar.
 * @style: the new style for @toolbar.
 * 
 * Alters the view of @toolbar to display either icons only, text only, or both.
 **/
void
gtk24_toolbar_set_style (Gtk24Toolbar      *toolbar,
		       GtkToolbarStyle  style)
{
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  toolbar->style_set = TRUE;  
  g_signal_emit (toolbar, toolbar_signals[STYLE_CHANGED], 0, style);
}

/**
 * gtk24_toolbar_get_style:
 * @toolbar: a #GtkToolbar
 *
 * Retrieves whether the toolbar has text, icons, or both . See
 * gtk24_toolbar_set_style().
 
 * Return value: the current style of @toolbar
 **/
GtkToolbarStyle
gtk24_toolbar_get_style (Gtk24Toolbar *toolbar)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), DEFAULT_TOOLBAR_STYLE);
  
  return toolbar->style;
}

/**
 * gtk24_toolbar_unset_style:
 * @toolbar: a #GtkToolbar
 * 
 * Unsets a toolbar style set with gtk24_toolbar_set_style(), so that
 * user preferences will be used to determine the toolbar style.
 **/
void
gtk24_toolbar_unset_style (Gtk24Toolbar *toolbar)
{
  GtkToolbarStyle style;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  if (toolbar->style_set)
    {
      GtkSettings *settings = toolbar_get_settings (toolbar);
      
      if (settings)
	g_object_get (settings,
		      "gtk-toolbar-style", &style,
		      NULL);
      else
	style = DEFAULT_TOOLBAR_STYLE;
      
      if (style != toolbar->style)
	g_signal_emit (toolbar, toolbar_signals[STYLE_CHANGED], 0, style);
      
      toolbar->style_set = FALSE;
    }
}

/**
 * gtk24_toolbar_set_tooltips:
 * @toolbar: a #GtkToolbar.
 * @enable: set to %FALSE to disable the tooltips, or %TRUE to enable them.
 * 
 * Sets if the tooltips of a toolbar should be active or not.
 **/
void
gtk24_toolbar_set_tooltips (Gtk24Toolbar *toolbar,
			  gboolean    enable)
{
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  if (enable)
    gtk_tooltips_enable (toolbar->tooltips);
  else
    gtk_tooltips_disable (toolbar->tooltips);
}

/**
 * gtk24_toolbar_get_tooltips:
 * @toolbar: a #GtkToolbar
 *
 * Retrieves whether tooltips are enabled. See
 * gtk24_toolbar_set_tooltips().
 *
 * Return value: %TRUE if tooltips are enabled
 **/
gboolean
gtk24_toolbar_get_tooltips (Gtk24Toolbar *toolbar)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), FALSE);
  
  return toolbar->tooltips->enabled;
}

/**
 * gtk24_toolbar_get_n_items:
 * @toolbar: a #GtkToolbar
 * 
 * Returns the number of items on the toolbar.
 * 
 * Return value: the number of items on the toolbar
 * 
 * Since: 2.4
 **/
gint
gtk24_toolbar_get_n_items (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv;
  
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), -1);
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return -1;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  return physical_to_logical (toolbar, g_list_length (priv->content));
}

/**
 * gtk24_toolbar_get_nth_item:
 * @toolbar: a #GtkToolbar
 * @n: A position on the toolbar
 *
 * Returns the @n<!-- -->'s item on @toolbar, or %NULL if the
 * toolbar does not contain an @n<!-- -->'th item.
 * 
 * Return value: The @n<!-- -->'th #GtkToolItem on @toolbar, or %NULL if there
 * isn't an @n<!-- -->th item.
 * 
 * Since: 2.4
 **/
GtkToolItem *
gtk24_toolbar_get_nth_item (Gtk24Toolbar *toolbar,
			  gint        n)
{
  Gtk24ToolbarPrivate *priv;
  ToolbarContent *content;
  gint n_items;
  
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), NULL);
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return NULL;
  
  n_items = gtk24_toolbar_get_n_items (toolbar);
  
  if (n < 0 || n >= n_items)
    return NULL;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  content = g_list_nth_data (priv->content, logical_to_physical (toolbar, n));
  
  g_assert (content);
  g_assert (!toolbar_content_is_placeholder (content));
  
  return GTK_TOOL_ITEM (toolbar_content_get_widget (content));
}

/**
 * gtk24_toolbar_get_icon_size:
 * @toolbar: a #GtkToolbar
 *
 * Retrieves the icon size fo the toolbar. See gtk24_toolbar_set_icon_size().
 *
 * Return value: the current icon size for the icons on the toolbar.
 **/
GtkIconSize
gtk24_toolbar_get_icon_size (Gtk24Toolbar *toolbar)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), DEFAULT_ICON_SIZE);
  
  return toolbar->icon_size;
}

/**
 * gtk24_toolbar_get_relief_style:
 * @toolbar: a #GtkToolbar
 * 
 * Returns the relief style of buttons on @toolbar. See
 * gtk_button_set_relief().
 * 
 * Return value: The relief style of buttons on @toolbar.
 * 
 * Since: 2.4
 **/
GtkReliefStyle
gtk24_toolbar_get_relief_style (Gtk24Toolbar *toolbar)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), GTK_RELIEF_NONE);
  
  return get_button_relief (toolbar);
}

/**
 * gtk24_toolbar_set_show_arrow:
 * @toolbar: a #GtkToolbar
 * @show_arrow: Whether to show an overflow menu
 * 
 * Sets whether to show an overflow menu when
 * @toolbar doesn't have room for all items on it. If %TRUE,
 * items that there are not room are available through an
 * overflow menu.
 * 
 * Since: 2.4
 **/
void
gtk24_toolbar_set_show_arrow (Gtk24Toolbar *toolbar,
			    gboolean    show_arrow)
{
  Gtk24ToolbarPrivate *priv;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  show_arrow = show_arrow != FALSE;
  
  if (priv->show_arrow != show_arrow)
    {
      priv->show_arrow = show_arrow;
      
      if (!priv->show_arrow)
	gtk_widget_hide (priv->arrow_button);
      
      gtk_widget_queue_resize (GTK_WIDGET (toolbar));      
      g_object_notify (G_OBJECT (toolbar), "show_arrow");
    }
}

/**
 * gtk24_toolbar_get_show_arrow:
 * @toolbar: a #GtkToolbar
 * 
 * Returns whether the toolbar has an overflow menu.
 * See gtk24_toolbar_set_show_arrow()
 * 
 * Return value: 
 * 
 * Since: 2.4
 **/
gboolean
gtk24_toolbar_get_show_arrow (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv;
  
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), FALSE);
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return FALSE;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  return priv->show_arrow;
}

/**
 * gtk24_toolbar_get_drop_index:
 * @toolbar: a #GtkToolbar
 * @x: x coordinate of a point on the toolbar
 * @y: y coordinate of a point on the toolbar
 *
 * Returns the position corresponding to the indicated point on
 * @toolbar. This is useful when dragging items to the toolbar:
 * this function returns the position a new item should be
 * inserted.
 *
 * @x and @y are in @toolbar coordinates.
 * 
 * Return value: The position corresponding to the point (@x, @y) on the toolbar.
 * 
 * Since: 2.4
 **/
gint
gtk24_toolbar_get_drop_index (Gtk24Toolbar *toolbar,
			    gint        x,
			    gint        y)
{
  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), -1);
  
  if (!gtk24_toolbar_check_new_api (toolbar))
    return -1;
  
  return physical_to_logical (toolbar, find_drop_index (toolbar, x, y));
}

static void
gtk24_toolbar_finalize (GObject *object)
{
  GList *list;
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (object);
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (toolbar->tooltips)
    g_object_unref (toolbar->tooltips);
  
  for (list = priv->content; list != NULL; list = list->next)
    {
      ToolbarContent *content = list->data;

      toolbar_content_free (content);
    }
  
  g_list_free (priv->content);
  g_list_free (toolbar->children);
  
  g_timer_destroy (priv->timer);
  
  if (priv->menu)
    gtk_widget_destroy (GTK_WIDGET (priv->menu));
  
  if (priv->idle_id)
    g_source_remove (priv->idle_id);
  
  g_free(priv);

  G_OBJECT_CLASS (parent_class)->finalize (object);
}

/*
 * Deprecated API
 */

/**
 * gtk24_toolbar_set_icon_size:
 * @toolbar: A #GtkToolbar
 * @icon_size: The #GtkIconSize that stock icons in the toolbar shall have.
 *
 * This function sets the size of stock icons in the toolbar. You
 * can call it both before you add the icons and after they've been
 * added. The size you set will override user preferences for the default
 * icon size.
 **/
void
gtk24_toolbar_set_icon_size (Gtk24Toolbar  *toolbar,
			   GtkIconSize  icon_size)
{
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  toolbar->icon_size_set = TRUE;
  
  if (toolbar->icon_size == icon_size)
    return;
  
  toolbar->icon_size = icon_size;
  
  gtk24_toolbar_reconfigured (toolbar);
  
  gtk_widget_queue_resize (GTK_WIDGET (toolbar));
}

/**
 * gtk24_toolbar_unset_icon_size:
 * @toolbar: a #GtkToolbar
 * 
 * Unsets toolbar icon size set with gtk24_toolbar_set_icon_size(), so that
 * user preferences will be used to determine the icon size.
 **/
void
gtk24_toolbar_unset_icon_size (Gtk24Toolbar *toolbar)
{
  GtkIconSize size;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  if (toolbar->icon_size_set)
    {
      GtkSettings *settings = toolbar_get_settings (toolbar);
      
      if (settings)
	{
	  g_object_get (settings,
			"gtk-toolbar-icon-size", &size,
			NULL);
	}
      else
	size = DEFAULT_ICON_SIZE;
      
      if (size != toolbar->icon_size)
	gtk24_toolbar_set_icon_size (toolbar, size);
      
      toolbar->icon_size_set = FALSE;
    }
}

/**
 * gtk24_toolbar_append_item:
 * @toolbar: a #GtkToolbar.
 * @text: give your toolbar button a label.
 * @tooltip_text: a string that appears when the user holds the mouse over this item.
 * @tooltip_private_text: use with #GtkTipsQuery.
 * @icon: a #GtkWidget that should be used as the button's icon.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: a pointer to any data you wish to be passed to the callback.
 * 
 * Inserts a new item into the toolbar. You must specify the position
 * in the toolbar where it will be inserted.
 *
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar item as a #GtkWidget.
 **/
GtkWidget *
gtk24_toolbar_append_item (Gtk24Toolbar    *toolbar,
			 const char    *text,
			 const char    *tooltip_text,
			 const char    *tooltip_private_text,
			 GtkWidget     *icon,
			 GtkSignalFunc  callback,
			 gpointer       user_data)
{
  return gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_BUTTON,
				     NULL, text,
				     tooltip_text, tooltip_private_text,
				     icon, callback, user_data,
				     toolbar->num_children);
}

/**
 * gtk24_toolbar_prepend_item:
 * @toolbar: a #GtkToolbar.
 * @text: give your toolbar button a label.
 * @tooltip_text: a string that appears when the user holds the mouse over this item.
 * @tooltip_private_text: use with #GtkTipsQuery.
 * @icon: a #GtkWidget that should be used as the button's icon.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: a pointer to any data you wish to be passed to the callback.
 * 
 * Adds a new button to the beginning (top or left edges) of the given toolbar.
 *
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar item as a #GtkWidget.
 **/
GtkWidget *
gtk24_toolbar_prepend_item (Gtk24Toolbar    *toolbar,
			  const char    *text,
			  const char    *tooltip_text,
			  const char    *tooltip_private_text,
			  GtkWidget     *icon,
			  GtkSignalFunc  callback,
			  gpointer       user_data)
{
  return gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_BUTTON,
				     NULL, text,
				     tooltip_text, tooltip_private_text,
				     icon, callback, user_data,
				     0);
}

/**
 * gtk24_toolbar_insert_item:
 * @toolbar: a #GtkToolbar.
 * @text: give your toolbar button a label.
 * @tooltip_text: a string that appears when the user holds the mouse over this item.
 * @tooltip_private_text: use with #GtkTipsQuery.
 * @icon: a #GtkWidget that should be used as the button's icon.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: a pointer to any data you wish to be passed to the callback.
 * @position: the number of widgets to insert this item after.
 * 
 * Inserts a new item into the toolbar. You must specify the position in the
 * toolbar where it will be inserted.
 *
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar item as a #GtkWidget.
 **/
GtkWidget *
gtk24_toolbar_insert_item (Gtk24Toolbar    *toolbar,
			 const char    *text,
			 const char    *tooltip_text,
			 const char    *tooltip_private_text,
			 GtkWidget     *icon,
			 GtkSignalFunc  callback,
			 gpointer       user_data,
			 gint           position)
{
  return gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_BUTTON,
				     NULL, text,
				     tooltip_text, tooltip_private_text,
				     icon, callback, user_data,
				     position);
}

/**
 * gtk24_toolbar_insert_stock:
 * @toolbar: A #GtkToolbar
 * @stock_id: The id of the stock item you want to insert
 * @tooltip_text: The text in the tooltip of the toolbar button
 * @tooltip_private_text: The private text of the tooltip
 * @callback: The callback called when the toolbar button is clicked.
 * @user_data: user data passed to callback
 * @position: The position the button shall be inserted at.
 *            -1 means at the end.
 *
 * Inserts a stock item at the specified position of the toolbar.  If
 * @stock_id is not a known stock item ID, it's inserted verbatim,
 * except that underscores used to mark mnemonics are removed.
 *
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Returns: the inserted widget
 */
GtkWidget*
gtk24_toolbar_insert_stock (Gtk24Toolbar      *toolbar,
			  const gchar     *stock_id,
			  const char      *tooltip_text,
			  const char      *tooltip_private_text,
			  GtkSignalFunc    callback,
			  gpointer         user_data,
			  gint             position)
{
  return internal_insert_element (toolbar, GTK24_TOOLBAR_CHILD_BUTTON,
				  NULL, stock_id,
				  tooltip_text, tooltip_private_text,
				  NULL, callback, user_data,
				  position, TRUE);
}

/**
 * gtk24_toolbar_append_space:
 * @toolbar: a #GtkToolbar.
 * 
 * Adds a new space to the end of the toolbar.
 **/
void
gtk24_toolbar_append_space (Gtk24Toolbar *toolbar)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_SPACE,
			      NULL, NULL,
			      NULL, NULL,
			      NULL, NULL, NULL,
			      toolbar->num_children);
}

/**
 * gtk24_toolbar_prepend_space:
 * @toolbar: a #GtkToolbar.
 * 
 * Adds a new space to the beginning of the toolbar.
 **/
void
gtk24_toolbar_prepend_space (Gtk24Toolbar *toolbar)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_SPACE,
			      NULL, NULL,
			      NULL, NULL,
			      NULL, NULL, NULL,
			      0);
}

/**
 * gtk24_toolbar_insert_space:
 * @toolbar: a #GtkToolbar
 * @position: the number of widgets after which a space should be inserted.
 * 
 * Inserts a new space in the toolbar at the specified position.
 **/
void
gtk24_toolbar_insert_space (Gtk24Toolbar *toolbar,
			  gint        position)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_SPACE,
			      NULL, NULL,
			      NULL, NULL,
			      NULL, NULL, NULL,
			      position);
}

/**
 * gtk24_toolbar_remove_space:
 * @toolbar: a #GtkToolbar.
 * @position: the index of the space to remove.
 * 
 * Removes a space from the specified position.
 **/
void
gtk24_toolbar_remove_space (Gtk24Toolbar *toolbar,
			  gint        position)
{
  Gtk24ToolbarPrivate *priv;
  ToolbarContent *content;
  
  g_return_if_fail (GTK24_IS_TOOLBAR (toolbar));
  
  if (!gtk24_toolbar_check_old_api (toolbar))
    return;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  content = g_list_nth_data (priv->content, position);
  
  if (!content)
    {
      g_warning ("Toolbar position %d doesn't exist", position);
      return;
    }
  
  if (!toolbar_content_is_separator (content))
    {
      g_warning ("Toolbar position %d is not a space", position);
      return;
    }
  
  toolbar_content_remove (content, toolbar);
  toolbar_content_free (content);
}

/**
 * gtk24_toolbar_append_widget:
 * @toolbar: a #GtkToolbar.
 * @widget: a #GtkWidget to add to the toolbar. 
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * 
 * Adds a widget to the end of the given toolbar.
 **/ 
void
gtk24_toolbar_append_widget (Gtk24Toolbar  *toolbar,
			   GtkWidget   *widget,
			   const gchar *tooltip_text,
			   const gchar *tooltip_private_text)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_WIDGET,
			      widget, NULL,
			      tooltip_text, tooltip_private_text,
			      NULL, NULL, NULL,
			      toolbar->num_children);
}

/**
 * gtk24_toolbar_prepend_widget:
 * @toolbar: a #GtkToolbar.
 * @widget: a #GtkWidget to add to the toolbar. 
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * 
 * Adds a widget to the beginning of the given toolbar.
 **/ 
void
gtk24_toolbar_prepend_widget (Gtk24Toolbar  *toolbar,
			    GtkWidget   *widget,
			    const gchar *tooltip_text,
			    const gchar *tooltip_private_text)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_WIDGET,
			      widget, NULL,
			      tooltip_text, tooltip_private_text,
			      NULL, NULL, NULL,
			      0);
}

/**
 * gtk24_toolbar_insert_widget:
 * @toolbar: a #GtkToolbar.
 * @widget: a #GtkWidget to add to the toolbar. 
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * @position: the number of widgets to insert this widget after.
 * 
 * Inserts a widget in the toolbar at the given position.
 **/ 
void
gtk24_toolbar_insert_widget (Gtk24Toolbar *toolbar,
			   GtkWidget  *widget,
			   const char *tooltip_text,
			   const char *tooltip_private_text,
			   gint        position)
{
  gtk24_toolbar_insert_element (toolbar, GTK24_TOOLBAR_CHILD_WIDGET,
			      widget, NULL,
			      tooltip_text, tooltip_private_text,
			      NULL, NULL, NULL,
			      position);
}

/**
 * gtk24_toolbar_append_element:
 * @toolbar: a #GtkToolbar.
 * @type: a value of type #Gtk24ToolbarChildType that determines what @widget will be.
 * @widget: a #GtkWidget, or %NULL.
 * @text: the element's label.
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * @icon: a #GtkWidget that provides pictorial representation of the element's function.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: any data you wish to pass to the callback.
 * 
 * Adds a new element to the end of a toolbar.
 * 
 * If @type == %GTK24_TOOLBAR_CHILD_WIDGET, @widget is used as the new element.
 * If @type == %GTK24_TOOLBAR_CHILD_RADIOBUTTON, @widget is used to determine
 * the radio group for the new element. In all other cases, @widget must
 * be %NULL.
 * 
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar element as a #GtkWidget.
 **/
GtkWidget*
gtk24_toolbar_append_element (Gtk24Toolbar          *toolbar,
			    Gtk24ToolbarChildType  type,
			    GtkWidget           *widget,
			    const char          *text,
			    const char          *tooltip_text,
			    const char          *tooltip_private_text,
			    GtkWidget           *icon,
			    GtkSignalFunc        callback,
			    gpointer             user_data)
{
  return gtk24_toolbar_insert_element (toolbar, type, widget, text,
				     tooltip_text, tooltip_private_text,
				     icon, callback, user_data,
				     toolbar->num_children);
}

/**
 * gtk24_toolbar_prepend_element:
 * @toolbar: a #GtkToolbar.
 * @type: a value of type #Gtk24ToolbarChildType that determines what @widget will be.
 * @widget: a #GtkWidget, or %NULL
 * @text: the element's label.
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * @icon: a #GtkWidget that provides pictorial representation of the element's function.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: any data you wish to pass to the callback.
 *  
 * Adds a new element to the beginning of a toolbar.
 * 
 * If @type == %GTK24_TOOLBAR_CHILD_WIDGET, @widget is used as the new element.
 * If @type == %GTK24_TOOLBAR_CHILD_RADIOBUTTON, @widget is used to determine
 * the radio group for the new element. In all other cases, @widget must
 * be %NULL.
 * 
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar element as a #GtkWidget.
 **/
GtkWidget *
gtk24_toolbar_prepend_element (Gtk24Toolbar          *toolbar,
			     Gtk24ToolbarChildType  type,
			     GtkWidget           *widget,
			     const char          *text,
			     const char          *tooltip_text,
			     const char          *tooltip_private_text,
			     GtkWidget           *icon,
			     GtkSignalFunc        callback,
			     gpointer             user_data)
{
  return gtk24_toolbar_insert_element (toolbar, type, widget, text,
				     tooltip_text, tooltip_private_text,
				     icon, callback, user_data, 0);
}

/**
 * gtk24_toolbar_insert_element:
 * @toolbar: a #GtkToolbar.
 * @type: a value of type #Gtk24ToolbarChildType that determines what @widget
 *   will be.
 * @widget: a #GtkWidget, or %NULL. 
 * @text: the element's label.
 * @tooltip_text: the element's tooltip.
 * @tooltip_private_text: used for context-sensitive help about this toolbar element.
 * @icon: a #GtkWidget that provides pictorial representation of the element's function.
 * @callback: the function to be executed when the button is pressed.
 * @user_data: any data you wish to pass to the callback.
 * @position: the number of widgets to insert this element after.
 *
 * Inserts a new element in the toolbar at the given position. 
 *
 * If @type == %GTK24_TOOLBAR_CHILD_WIDGET, @widget is used as the new element.
 * If @type == %GTK24_TOOLBAR_CHILD_RADIOBUTTON, @widget is used to determine
 * the radio group for the new element. In all other cases, @widget must
 * be %NULL.
 *
 * @callback must be a pointer to a function taking a #GtkWidget and a gpointer as
 * arguments. Use the GTK_SIGNAL_FUNC() to cast the function to #GtkSignalFunc.
 *
 * Return value: the new toolbar element as a #GtkWidget.
 **/
GtkWidget *
gtk24_toolbar_insert_element (Gtk24Toolbar          *toolbar,
			    Gtk24ToolbarChildType  type,
			    GtkWidget           *widget,
			    const char          *text,
			    const char          *tooltip_text,
			    const char          *tooltip_private_text,
			    GtkWidget           *icon,
			    GtkSignalFunc        callback,
			    gpointer             user_data,
			    gint                 position)
{
  return internal_insert_element (toolbar, type, widget, text,
				  tooltip_text, tooltip_private_text,
				  icon, callback, user_data, position, FALSE);
}

static void
set_child_packing_and_visibility(Gtk24Toolbar      *toolbar,
                                 Gtk24ToolbarChild *child)
{
  GtkWidget *box;
  gboolean   expand;

  box = gtk_bin_get_child (GTK_BIN (child->widget));
  
  g_return_if_fail (GTK_IS_BOX (box));
  
  if (child->label)
    {
      expand = (toolbar->style != GTK_TOOLBAR_BOTH);
      
      gtk_box_set_child_packing (GTK_BOX (box), child->label,
                                 expand, expand, 0, GTK_PACK_END);
      
      if (toolbar->style != GTK_TOOLBAR_ICONS)
        gtk_widget_show (child->label);
      else
        gtk_widget_hide (child->label);
    }
  
  if (child->icon)
    {
      expand = (toolbar->style != GTK_TOOLBAR_BOTH_HORIZ);
      
      gtk_box_set_child_packing (GTK_BOX (box), child->icon,
                                 expand, expand, 0, GTK_PACK_END);
      
      if (toolbar->style != GTK_TOOLBAR_TEXT)
        gtk_widget_show (child->icon);
      else
        gtk_widget_hide (child->icon);
    }
}

static GtkWidget *
internal_insert_element (Gtk24Toolbar          *toolbar,
			 Gtk24ToolbarChildType  type,
			 GtkWidget           *widget,
			 const char          *text,
			 const char          *tooltip_text,
			 const char          *tooltip_private_text,
			 GtkWidget           *icon,
			 GtkSignalFunc        callback,
			 gpointer             user_data,
			 gint                 position,
			 gboolean             use_stock)
{
  GtkWidget *box;
  ToolbarContent *content;
  Gtk24ToolbarPrivate *priv;
  char *free_me = NULL;
  gboolean is_button = FALSE;

  GtkWidget *child_widget;
  GtkWidget *child_label;
  GtkWidget *child_icon;

  g_return_val_if_fail (GTK24_IS_TOOLBAR (toolbar), NULL);
  if (type == GTK24_TOOLBAR_CHILD_WIDGET)
    g_return_val_if_fail (GTK_IS_WIDGET (widget), NULL);
  else if (type != GTK24_TOOLBAR_CHILD_RADIOBUTTON)
    g_return_val_if_fail (widget == NULL, NULL);
  
  if (!gtk24_toolbar_check_old_api (toolbar))
    return NULL;
  
  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  child_widget = NULL;
  child_label = NULL;
  child_icon = NULL;
  
  switch (type)
    {
    case GTK24_TOOLBAR_CHILD_SPACE:
      break;
      
    case GTK24_TOOLBAR_CHILD_WIDGET:
      child_widget = widget;
      break;
      
    case GTK24_TOOLBAR_CHILD_BUTTON:
    case GTK24_TOOLBAR_CHILD_TOGGLEBUTTON:
    case GTK24_TOOLBAR_CHILD_RADIOBUTTON:
      is_button = TRUE;
      if (type == GTK24_TOOLBAR_CHILD_BUTTON)
	{
	  child_widget = gtk_button_new ();
	}
      else if (type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON)
	{
	  child_widget = gtk_toggle_button_new ();
	  gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (child_widget), FALSE);
	}
      else /* type == GTK24_TOOLBAR_CHILD_RADIOBUTTON */
	{
	  GSList *group = NULL;

	  if (widget)
	    group = gtk_radio_button_get_group (GTK_RADIO_BUTTON (widget));
	  
	  child_widget = gtk_radio_button_new (group);
	  gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (child_widget), FALSE);
	}

      gtk_button_set_relief (GTK_BUTTON (child_widget), get_button_relief (toolbar));
      gtk_button_set_focus_on_click (GTK_BUTTON (child_widget), FALSE);
      
      if (callback)
	{
	  g_signal_connect (child_widget, "clicked",
			    callback, user_data);
	}
      
      if (toolbar->style == GTK_TOOLBAR_BOTH_HORIZ)
	box = gtk_hbox_new (FALSE, 0);
      else
	box = gtk_vbox_new (FALSE, 0);

      gtk_container_add (GTK_CONTAINER (child_widget), box);
      gtk_widget_show (box);
      
      if (text && use_stock)
	{
	  GtkStockItem stock_item;
	  if (gtk_stock_lookup (text, &stock_item))
	    {
	      if (!icon)
		icon = gtk_image_new_from_stock (text, toolbar->icon_size);
	  
	      text = free_me = _gtk24_toolbar_elide_underscores (stock_item.label);
	    }
	}
      
      if (text)
	{
	  child_label = gtk_label_new (text);
	  
	  gtk_container_add (GTK_CONTAINER (box), child_label);
	}
      
      if (icon)
	{
	  child_icon = GTK_WIDGET (icon);
          gtk_container_add (GTK_CONTAINER (box), child_icon);
	}
      
      gtk_widget_show (child_widget);
      break;
      
    default:
      g_assert_not_reached ();
      break;
    }
  
  if ((type != GTK24_TOOLBAR_CHILD_SPACE) && tooltip_text)
    {
      gtk_tooltips_set_tip (toolbar->tooltips, child_widget,
			    tooltip_text, tooltip_private_text);
    }
  
  content = toolbar_content_new_compatibility (toolbar, type, child_widget,
					       child_icon, child_label, position);
  
  if (free_me)
    g_free (free_me);
  
  return child_widget;
}

/*
 * ToolbarContent methods
 */
struct _ToolbarContent
{
  ContentType	type;
  ItemState	state;
  
  union
  {
    struct
    {
      GtkToolItem *	item;
      GtkAllocation	start_allocation;
      GtkAllocation	goal_allocation;
      guint		is_placeholder : 1;
      guint		disappearing : 1;
    } tool_item;
    
    struct
    {
      Gtk24ToolbarChild	child;
      GtkAllocation	space_allocation;
      guint		space_visible : 1;
    } compatibility;
  } u;
};

static ToolbarContent *
toolbar_content_new_tool_item (Gtk24Toolbar  *toolbar,
			       GtkToolItem *item,
			       gboolean     is_placeholder,
			       gint	    pos)
{
  ToolbarContent *content;
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  content = g_new0 (ToolbarContent, 1);
  
  content->type = TOOL_ITEM;
  content->state = NOT_ALLOCATED;
  content->u.tool_item.item = item;
  content->u.tool_item.is_placeholder = is_placeholder;
  
  gtk_widget_set_parent (GTK_WIDGET (item), GTK_WIDGET (toolbar));

  priv->content = g_list_insert (priv->content, content, pos);
  
  if (!is_placeholder)
    {
      toolbar->num_children++;

      gtk24_toolbar_stop_sliding (toolbar);
    }

  gtk_widget_queue_resize (GTK_WIDGET (toolbar));
  
  return content;
}

static ToolbarContent *
toolbar_content_new_compatibility (Gtk24Toolbar          *toolbar,
				   Gtk24ToolbarChildType  type,
				   GtkWidget		*widget,
				   GtkWidget		*icon,
				   GtkWidget		*label,
				   gint			 pos)
{
  ToolbarContent *content;
  Gtk24ToolbarChild *child;
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  content = g_new0 (ToolbarContent, 1);

  child = &(content->u.compatibility.child);
  
  content->type = COMPATIBILITY;
  child->type = type;
  child->widget = widget;
  child->icon = icon;
  child->label = label;
  
  if (type != GTK24_TOOLBAR_CHILD_SPACE)
    {
      gtk_widget_set_parent (child->widget, GTK_WIDGET (toolbar));
    }
  else
    {
      content->u.compatibility.space_visible = TRUE;
      gtk_widget_queue_resize (GTK_WIDGET (toolbar));
    }
 
  if (type == GTK24_TOOLBAR_CHILD_BUTTON ||
      type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON ||
      type == GTK24_TOOLBAR_CHILD_RADIOBUTTON)
    {
      set_child_packing_and_visibility (toolbar, child);
    }

  priv->content = g_list_insert (priv->content, content, pos);
  toolbar->children = g_list_insert (toolbar->children, child, pos);
  
  toolbar->num_children++;
  
  return content;
}

static void
toolbar_content_remove (ToolbarContent *content,
			Gtk24Toolbar     *toolbar)
{
  Gtk24ToolbarChild *child;
  Gtk24ToolbarPrivate *priv;

  priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  switch (content->type)
    {
    case TOOL_ITEM:
      gtk_widget_unparent (GTK_WIDGET (content->u.tool_item.item));
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      
      if (child->type != GTK24_TOOLBAR_CHILD_SPACE)
	{
	  g_object_ref (child->widget);
	  gtk_widget_unparent (child->widget);
	  gtk_widget_destroy (child->widget);
	  g_object_unref (child->widget);
	}
      
      toolbar->children = g_list_remove (toolbar->children, child);
      break;
    }

  priv->content = g_list_remove (priv->content, content);

  if (!toolbar_content_is_placeholder (content))
    toolbar->num_children--;

  gtk_widget_queue_resize (GTK_WIDGET (toolbar));
}

static void
toolbar_content_free (ToolbarContent *content)
{
  g_free (content);
}

static gint
calculate_max_homogeneous_pixels (GtkWidget *widget)
{
  PangoContext *context;
  PangoFontMetrics *metrics;
  gint char_width;
  
  context = gtk_widget_get_pango_context (widget);
  metrics = pango_context_get_metrics (context,
				       widget->style->font_desc,
				       pango_context_get_language (context));
  char_width = pango_font_metrics_get_approximate_char_width (metrics);
  pango_font_metrics_unref (metrics);
  
  return PANGO_PIXELS (MAX_HOMOGENEOUS_N_CHARS * char_width);
}

static void
toolbar_content_expose (ToolbarContent *content,
			GtkContainer   *container,
			GdkEventExpose *expose)
{
  Gtk24Toolbar *toolbar = GTK24_TOOLBAR (container);
  Gtk24ToolbarChild *child;
  GtkWidget *widget = NULL; /* quiet gcc */
  
  switch (content->type)
    {
    case TOOL_ITEM:
      if (!content->u.tool_item.is_placeholder)
	widget = GTK_WIDGET (content->u.tool_item.item);
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      
      if (child->type == GTK24_TOOLBAR_CHILD_SPACE)
	{
	  if (get_space_style (toolbar) == GTK24_TOOLBAR_SPACE_LINE &&
	      content->u.compatibility.space_visible)
	    {
	      _gtk24_toolbar_paint_space_line (GTK_WIDGET (toolbar), toolbar,
					     &expose->area,
					     &content->u.compatibility.space_allocation);
	    }
	  return;
	}
      
      widget = child->widget;
      break;
    }
  
  if (widget)
    gtk_container_propagate_expose (container, widget, expose);
}

static gboolean
toolbar_content_visible (ToolbarContent *content,
			 Gtk24Toolbar     *toolbar)
{
  GtkToolItem *item;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      item = content->u.tool_item.item;
      
      if (!GTK_WIDGET_VISIBLE (item))
	return FALSE;
      
      if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL &&
	  gtk_tool_item_get_visible_horizontal (item))
	{
	  return TRUE;
	}
      
      if ((toolbar->orientation == GTK_ORIENTATION_VERTICAL &&
	   gtk_tool_item_get_visible_vertical (item)))
	{
	  return TRUE;
	}
      
      return FALSE;
      break;
      
    case COMPATIBILITY:
      if (content->u.compatibility.child.type != GTK24_TOOLBAR_CHILD_SPACE)
	return GTK_WIDGET_VISIBLE (content->u.compatibility.child.widget);
      else
	return TRUE;
      break;
    }
  
  g_assert_not_reached ();
  return FALSE;
}

static void
toolbar_content_size_request (ToolbarContent *content,
			      Gtk24Toolbar     *toolbar,
			      GtkRequisition *requisition)
{
  gint space_size;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      gtk_widget_size_request (GTK_WIDGET (content->u.tool_item.item),
			       requisition);
      if (content->u.tool_item.is_placeholder &&
	  content->u.tool_item.disappearing)
	{
	  requisition->width = 0;
	  requisition->height = 0;
	}
      break;
      
    case COMPATIBILITY:
      space_size = get_space_size (toolbar);
      
      if (content->u.compatibility.child.type != GTK24_TOOLBAR_CHILD_SPACE)
	{
	  gtk_widget_size_request (content->u.compatibility.child.widget,
				   requisition);
	}
      else
	{
	  if (toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
	    {
	      requisition->width = space_size;
	      requisition->height = 0;
	    }
	  else
	    {
	      requisition->height = space_size;
	      requisition->width = 0;
	    }
	}
      
      break;
    }
}

static gboolean
toolbar_content_is_homogeneous (ToolbarContent *content,
				Gtk24Toolbar     *toolbar)
{
  gboolean result = FALSE;	/* quiet gcc */
  GtkRequisition requisition;
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (priv->max_homogeneous_pixels < 0)
    {
      priv->max_homogeneous_pixels =
	calculate_max_homogeneous_pixels (GTK_WIDGET (toolbar));
    }
  
  toolbar_content_size_request (content, toolbar, &requisition);
  
  if (requisition.width > priv->max_homogeneous_pixels)
    return FALSE;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      result = gtk_tool_item_get_homogeneous (content->u.tool_item.item) &&
	!GTK_IS_SEPARATOR_TOOL_ITEM (content->u.tool_item.item);
      
      if (gtk_tool_item_get_is_important (content->u.tool_item.item) &&
	  toolbar->style == GTK_TOOLBAR_BOTH_HORIZ &&
	  toolbar->orientation == GTK_ORIENTATION_HORIZONTAL)
	{
	  result = FALSE;
	}
      break;
      
    case COMPATIBILITY:
      if (content->u.compatibility.child.type == GTK24_TOOLBAR_CHILD_BUTTON ||
	  content->u.compatibility.child.type == GTK24_TOOLBAR_CHILD_RADIOBUTTON ||
	  content->u.compatibility.child.type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON)
	{
	  result = TRUE;
	}
      else
	{
	  result = FALSE;
	}
      break;
    }
  
  return result;
}

static gboolean
toolbar_content_is_placeholder (ToolbarContent *content)
{
  if (content->type == TOOL_ITEM && content->u.tool_item.is_placeholder)
    return TRUE;
  
  return FALSE;
}

static gboolean
toolbar_content_disappearing (ToolbarContent *content)
{
  if (content->type == TOOL_ITEM && content->u.tool_item.disappearing)
    return TRUE;
  
  return FALSE;
}

static ItemState
toolbar_content_get_state (ToolbarContent *content)
{
  return content->state;
}

static gboolean
toolbar_content_child_visible (ToolbarContent *content)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      return GTK_WIDGET_CHILD_VISIBLE (content->u.tool_item.item);
      break;
      
    case COMPATIBILITY:
      if (content->u.compatibility.child.type != GTK24_TOOLBAR_CHILD_SPACE)
	{
	  return GTK_WIDGET_CHILD_VISIBLE (content->u.compatibility.child.widget);
	}
      else
	{
	  return content->u.compatibility.space_visible;
	}
      break;
    }
  
  return FALSE; /* quiet gcc */
}

static void
toolbar_content_get_goal_allocation (ToolbarContent *content,
				     GtkAllocation  *allocation)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      *allocation = content->u.tool_item.goal_allocation;
      break;
      
    case COMPATIBILITY:
      /* Goal allocations are only relevant when we are
       * using the new API, so we should never get here
       */
      g_assert_not_reached ();
      break;
    }
}

static void
toolbar_content_get_allocation (ToolbarContent *content,
				GtkAllocation  *allocation)
{
  Gtk24ToolbarChild *child;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      *allocation = GTK_WIDGET (content->u.tool_item.item)->allocation;
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      
      if (child->type == GTK24_TOOLBAR_CHILD_SPACE)
	*allocation = content->u.compatibility.space_allocation;
      else
	*allocation = child->widget->allocation;
      break;
    }
}

static void
toolbar_content_set_start_allocation (ToolbarContent *content,
				      GtkAllocation  *allocation)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      content->u.tool_item.start_allocation = *allocation;
      break;
      
    case COMPATIBILITY:
      /* start_allocation is only relevant when using the new API */
      g_assert_not_reached ();
      break;
    }
}

static gboolean
toolbar_content_get_expand (ToolbarContent *content)
{
  if (content->type == TOOL_ITEM &&
      gtk_tool_item_get_expand (content->u.tool_item.item))
    {
      return TRUE;
    }
  
  return FALSE;
}

static void
toolbar_content_set_goal_allocation (ToolbarContent *content,
				     GtkAllocation  *allocation)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      content->u.tool_item.goal_allocation = *allocation;
      break;
      
    case COMPATIBILITY:
      /* Only relevant when using new API */
      g_assert_not_reached ();
      break;
    }
}

static void
toolbar_content_set_child_visible (ToolbarContent *content,
				   Gtk24Toolbar     *toolbar,
				   gboolean        visible)
{
  Gtk24ToolbarChild *child;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      gtk_widget_set_child_visible (GTK_WIDGET (content->u.tool_item.item),
				    visible);
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      
      if (child->type != GTK24_TOOLBAR_CHILD_SPACE)
	{
	  gtk_widget_set_child_visible (child->widget, visible);
	}
      else
	{
	  content->u.compatibility.space_visible = visible;
	  gtk_widget_queue_draw (GTK_WIDGET (toolbar));
	}
      break;
    }
}

static void
toolbar_content_get_start_allocation (ToolbarContent *content,
				      GtkAllocation  *start_allocation)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      *start_allocation = content->u.tool_item.start_allocation;
      break;
      
    case COMPATIBILITY:
      /* Only relevant for new API */
      g_assert_not_reached ();
      break;
    }
}

static void
toolbar_content_size_allocate (ToolbarContent *content,
			       GtkAllocation  *allocation)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      gtk_widget_size_allocate (GTK_WIDGET (content->u.tool_item.item),
				allocation);
      break;
      
    case COMPATIBILITY:
      if (content->u.compatibility.child.type != GTK24_TOOLBAR_CHILD_SPACE)
	{
	  gtk_widget_size_allocate (content->u.compatibility.child.widget,
				    allocation);
	}
      else
	{
	  content->u.compatibility.space_allocation = *allocation;
	}
      break;
    }
}

static void
toolbar_content_set_state (ToolbarContent *content,
			   ItemState       state)
{
  content->state = state;
}

static GtkWidget *
toolbar_content_get_widget (ToolbarContent *content)
{
  Gtk24ToolbarChild *child;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      return GTK_WIDGET (content->u.tool_item.item);
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      if (child->type != GTK24_TOOLBAR_CHILD_SPACE)
	return child->widget;
      else
	return NULL;
      break;
    }
  
  return NULL;
}

static void
toolbar_content_set_disappearing (ToolbarContent *content,
				  gboolean        disappearing)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      content->u.tool_item.disappearing = disappearing;
      break;
      
    case COMPATIBILITY:
      /* Only relevant for new API */
      g_assert_not_reached ();
      break;
    }
}

static void
toolbar_content_set_size_request (ToolbarContent *content,
				  gint            width,
				  gint            height)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      gtk_widget_set_size_request (GTK_WIDGET (content->u.tool_item.item),
				   width, height);
      break;
      
    case COMPATIBILITY:
      /* Setting size requests only happens with sliding,
       * so not relevant here
       */
      g_assert_not_reached ();
      break;
    }
}

static void
toolbar_child_reconfigure (Gtk24Toolbar      *toolbar,
			   Gtk24ToolbarChild *child)
{
  GtkWidget *box;
  GtkImage *image;
  GtkToolbarStyle style;
  GtkIconSize icon_size;
  GtkReliefStyle relief;
  gchar *stock_id;
  
  style = gtk24_toolbar_get_style (toolbar);
  icon_size = gtk24_toolbar_get_icon_size (toolbar);
  relief = gtk24_toolbar_get_relief_style (toolbar);
  
  /* style */
  if (child->type == GTK24_TOOLBAR_CHILD_BUTTON ||
      child->type == GTK24_TOOLBAR_CHILD_RADIOBUTTON ||
      child->type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON)
    {
      box = gtk_bin_get_child (GTK_BIN (child->widget));
      
      if (style == GTK_TOOLBAR_BOTH && GTK_IS_HBOX (box))
	{
	  GtkWidget *vbox;
	  
	  vbox = gtk_vbox_new (FALSE, 0);
	  
	  if (child->label)
	    gtk_widget_reparent (child->label, vbox);
	  if (child->icon)
	    gtk_widget_reparent (child->icon, vbox);
	  
	  gtk_widget_destroy (box);
	  gtk_container_add (GTK_CONTAINER (child->widget), vbox);
	  
	  gtk_widget_show (vbox);
	}
      else if (style == GTK_TOOLBAR_BOTH_HORIZ && GTK_IS_VBOX (box))
	{
	  GtkWidget *hbox;
	  
	  hbox = gtk_hbox_new (FALSE, 0);
	  
	  if (child->label)
	    gtk_widget_reparent (child->label, hbox);
	  if (child->icon)
	    gtk_widget_reparent (child->icon, hbox);
	  
	  gtk_widget_destroy (box);
	  gtk_container_add (GTK_CONTAINER (child->widget), hbox);
	  
	  gtk_widget_show (hbox);
	}

      set_child_packing_and_visibility (toolbar, child);
    }
  
  /* icon size */
  
  if ((child->type == GTK24_TOOLBAR_CHILD_BUTTON ||
       child->type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON ||
       child->type == GTK24_TOOLBAR_CHILD_RADIOBUTTON) &&
      GTK_IS_IMAGE (child->icon))
    {
      image = GTK_IMAGE (child->icon);
      if (gtk_image_get_storage_type (image) == GTK_IMAGE_STOCK)
	{
	  gtk_image_get_stock (image, &stock_id, NULL);
	  stock_id = g_strdup (stock_id);
	  gtk_image_set_from_stock (image,
				    stock_id,
				    icon_size);
	  g_free (stock_id);
	}
    }
  
  /* relief */
  if (child->type == GTK24_TOOLBAR_CHILD_BUTTON ||
      child->type == GTK24_TOOLBAR_CHILD_RADIOBUTTON ||
      child->type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON)
    {
      gtk_button_set_relief (GTK_BUTTON (child->widget), relief);
    }
}

static void
toolbar_content_toolbar_reconfigured (ToolbarContent *content,
				      Gtk24Toolbar     *toolbar)
{
  switch (content->type)
    {
    case TOOL_ITEM:
      _gtk_tool_item_toolbar_reconfigured (content->u.tool_item.item);
      break;
      
    case COMPATIBILITY:
      toolbar_child_reconfigure (toolbar, &(content->u.compatibility.child));
      break;
    }
}

static GtkWidget *
toolbar_content_retrieve_menu_item (ToolbarContent *content)
{
  if (content->type == TOOL_ITEM)
    return gtk_tool_item_retrieve_proxy_menu_item (content->u.tool_item.item);
  
  /* FIXME - we might actually be able to do something meaningful here */
  return NULL; 
}

static gboolean
toolbar_content_is_separator (ToolbarContent *content)
{
  Gtk24ToolbarChild *child;
  
  switch (content->type)
    {
    case TOOL_ITEM:
      return GTK_IS_SEPARATOR_TOOL_ITEM (content->u.tool_item.item);
      break;
      
    case COMPATIBILITY:
      child = &(content->u.compatibility.child);
      return (child->type == GTK24_TOOLBAR_CHILD_SPACE);
      break;
    }
  
  return FALSE;
}

static gboolean
ignore_show_and_hide_all (ToolbarContent *content)
{
  if (content->type == COMPATIBILITY)
    {
      Gtk24ToolbarChildType type = content->u.compatibility.child.type;
      
      if (type == GTK24_TOOLBAR_CHILD_BUTTON ||
	  type == GTK24_TOOLBAR_CHILD_TOGGLEBUTTON ||
	  type == GTK24_TOOLBAR_CHILD_RADIOBUTTON)
	{
	  return TRUE;
	}
    }
  
  return FALSE;
}

static void
toolbar_content_show_all (ToolbarContent  *content)
{
  GtkWidget *widget;
  
  if (ignore_show_and_hide_all (content))
    return;

  widget = toolbar_content_get_widget (content);
  if (widget)
    gtk_widget_show_all (widget);
}

static void
toolbar_content_hide_all (ToolbarContent  *content)
{
  GtkWidget *widget;
  
  if (ignore_show_and_hide_all (content))
    return;

  widget = toolbar_content_get_widget (content);
  if (widget)
    gtk_widget_hide_all (widget);
}

/*
 * Getters
 */
static gint
get_space_size (Gtk24Toolbar *toolbar)
{
  gint space_size = DEFAULT_SPACE_SIZE;
  
  if (toolbar)
    {
      gtk_widget_style_get (GTK_WIDGET (toolbar),
			    "space_size", &space_size,
			    NULL);
    }
  
  return space_size;
}

static Gtk24ToolbarSpaceStyle
get_space_style (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarSpaceStyle space_style = DEFAULT_SPACE_STYLE;

  if (toolbar)
    {
      gtk_widget_style_get (GTK_WIDGET (toolbar),
			    "space_style", &space_style,
			    NULL);
    }
  
  return space_style;  
}

static GtkReliefStyle
get_button_relief (Gtk24Toolbar *toolbar)
{
  GtkReliefStyle button_relief = GTK_RELIEF_NORMAL;
  
  gtk_widget_ensure_style (GTK_WIDGET (toolbar));
  
  gtk_widget_style_get (GTK_WIDGET (toolbar),
                        "button_relief", &button_relief,
                        NULL);
  
  return button_relief;
}

static gint
get_internal_padding (Gtk24Toolbar *toolbar)
{
  gint ipadding = 0;
  
  gtk_widget_style_get (GTK_WIDGET (toolbar),
			"internal_padding", &ipadding,
			NULL);
  
  return ipadding;
}

static GtkShadowType
get_shadow_type (Gtk24Toolbar *toolbar)
{
  GtkShadowType shadow_type;
  
  gtk_widget_style_get (GTK_WIDGET (toolbar),
			"shadow_type", &shadow_type,
			NULL);
  
  return shadow_type;
}

/*
 * API checks
 */
#define mixed_api_warning \
    "mixing deprecated and non-deprecated Gtk24Toolbar API is not allowed"

static gboolean
gtk24_toolbar_check_old_api (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (priv->api_mode == NEW_API)
    {
      g_warning (mixed_api_warning);
      return FALSE;
    }
  
  priv->api_mode = OLD_API;
  return TRUE;
}

static gboolean
gtk24_toolbar_check_new_api (Gtk24Toolbar *toolbar)
{
  Gtk24ToolbarPrivate *priv = GTK24_TOOLBAR_GET_PRIVATE (toolbar);
  
  if (priv->api_mode == OLD_API)
    {
      g_warning (mixed_api_warning);
      return FALSE;
    }
  
  priv->api_mode = NEW_API;
  return TRUE;
}

/* GTK+ internal methods */

gint
_gtk24_toolbar_get_default_space_size (void)
{
  return DEFAULT_SPACE_SIZE;
}

void
_gtk24_toolbar_paint_space_line (GtkWidget       *widget,
			       Gtk24Toolbar      *toolbar,
			       GdkRectangle    *area,
			       GtkAllocation   *allocation)
{
  const double start_fraction = (SPACE_LINE_START / SPACE_LINE_DIVISION);
  const double end_fraction = (SPACE_LINE_END / SPACE_LINE_DIVISION);
  
  gint space_size;
  Gtk24ToolbarSpaceStyle space_style;
  GtkOrientation orientation;

  g_return_if_fail (GTK_IS_WIDGET (widget));
  
  space_size = get_space_size (toolbar);
  space_style = get_space_style (toolbar);
  orientation = toolbar? toolbar->orientation : GTK_ORIENTATION_HORIZONTAL;

  if (orientation == GTK_ORIENTATION_HORIZONTAL)
    {
      gtk_paint_vline (widget->style, widget->window,
		       GTK_WIDGET_STATE (widget), area, widget,
		       "toolbar",
		       allocation->y + allocation->height * start_fraction,
		       allocation->y + allocation->height * end_fraction,
		       allocation->x + (space_size - widget->style->xthickness) / 2);
    }
  else
    {
      gtk_paint_hline (widget->style, widget->window,
		       GTK_WIDGET_STATE (widget), area, widget,
		       "toolbar",
		       allocation->x + allocation->width * start_fraction,
		       allocation->x + allocation->width * end_fraction,
		       allocation->y + (space_size - widget->style->ythickness) / 2);
    }
}

gchar *
_gtk24_toolbar_elide_underscores (const gchar *original)
{
  gchar *q, *result;
  const gchar *p;
  gboolean last_underscore;
  
  q = result = g_malloc (strlen (original) + 1);
  last_underscore = FALSE;
  
  for (p = original; *p; p++)
    {
      if (!last_underscore && *p == '_')
	last_underscore = TRUE;
      else
	{
	  last_underscore = FALSE;
	  *q++ = *p;
	}
    }
  
  *q = '\0';
  
  return result;
}

#endif /* USE_GTK_2_2 */
